WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 2 weeks ago

#40275 new enhancement

Use a monospace-type font to display passwords

Reported by: robdxw Owned by:
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Users Keywords: good-first-bug has-patch
Focuses: ui, css Cc:

Description

There are a number of places where passwords are echoed back to users e.g. in wp-activate.php when a user activates their account, or when a password is suggested when a user first registers.

Because these fields are generally displayed in Helvetica Neue or Arial, there is the potential for character confusion if a user transcribes their password, rather than copy-and-pasting. This would be eliminated by using a monospace-type font to display the password.

E.g. compare

lIo1O0loI

to

lIo1O0loI

Attachments (4)

Screen Shot 2017-03-27 at 14.47.23.png (38.1 KB) - added by robdxw 4 years ago.
Example on user profile age.
40275.diff (390 bytes) - added by utz119 11 months ago.
40275.png (50.2 KB) - added by utz119 11 months ago.
The monospace font has been added to the password field.
40275.1.diff (416 bytes) - added by Hareesh Pillai 2 weeks ago.
Patch updated against trunk

Download all attachments as: .zip

Change History (11)

@robdxw
4 years ago

Example on user profile age.

#1 @sabernhardt
11 months ago

  • Focuses ui css added
  • Keywords needs-design-feedback added
  • Version 4.8 deleted

This ticket was mentioned in Slack in #core by noisysocks. View the logs.


11 months ago

#3 @mikeschroder
11 months ago

  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

Sorry for the very slow response on this ticket!

It was brought up in triage today, and I think it's a great idea -- this seemed to be consensus in the meeting as well.

Moving it to Future Release, and adding good-first-bug so that it gets a bit more visibility from folks.

#4 @SergeyBiryukov
11 months ago

  • Component changed from General to Users

@utz119
11 months ago

@utz119
11 months ago

The monospace font has been added to the password field.

#5 @utz119
11 months ago

  • Keywords has-patch added

#6 @hedgefield
5 months ago

  • Keywords needs-design-feedback removed

Looks good! Thanks for making a patch, good suggestion. What needs to be done here to ship this?

@Hareesh Pillai
2 weeks ago

Patch updated against trunk

#7 @Hareesh Pillai
2 weeks ago

  • Milestone changed from Future Release to 5.8

This ticket has design feedback and an updated patch.
Adding it to the upcoming milestone.

Note: See TracTickets for help on using tickets.