Adding page created with the dropdown-pages settings to menu creates Custom Link instead of Page

[danielmilner]

How to recreate the issue in Customize:

1. Create a new page using a dropdown-pages setting that has the allow_addition option.
2. Switch to the menu panel, and add this newly created page to a Menu. (It shows up as a Page)
3. Save changes and exit the Customize screen.

View the menu on the front-end. The menu item was added to the menu as a Custom Link instead of a Page.

[danielmilner]

This only happens during the Customize session where the Page was created. If you Save/Exit and return to the Customize screen, the menu item will be added correctly.

[westonruter]

@danielmilner good catch. Would you give 40277.0.diff​ a try? Looks like we got the values for type and object reversed.

[lukecavanagh]

40277.0.diff​ seems to fix the issue, when through the same steps and added the newly created page to an existing menu in the Customizer, when checking the site front-end the page added to the main menu was a page and not a custom link.

[danielmilner]

I concur with @lukecavanagh. 40277.0.diff​ appears to fix the issue.

[westonruter]

In 40380:

Customize: Fix reversal of nav menu item's type and object properties for page stub added in customizer.

Amends [38906].
See #38164.
Fixes #40277.

[westonruter]

Re-opening for consideration in 4.7.4

[swissspidy]

In 40383:

Customize: Fix reversal of nav menu item's type and object properties for
page stub added in customizer.

Amends [38906].
See #38164.
Fixes #40277.

Merges [40380] to the 4.7 branch.