id,summary,reporter,owner,description,type,status,priority,milestone,component,version,severity,resolution,keywords,cc,focuses 4027,Upgrade function don't do ANY error checking whatsoever,skjaeve,,"When I upgraded from 2.0.5 to 2.1.2, there was an error in my MySQL privileges, so the ALTER TABLE commands failed: {{{ WordPress database error: [ALTER command denied to user 'aasmunds'@'localhost' for table 'wp_categories'] ALTER TABLE wp_categories ADD COLUMN link_count bigint(20) NOT NULL default '0' WordPress database error: [ALTER command denied to user 'aasmunds'@'localhost' for table 'wp_categories'] ALTER TABLE wp_categories ADD COLUMN posts_private tinyint(1) NOT NULL default '0' WordPress database error: [ALTER command denied to user 'aasmunds'@'localhost' for table 'wp_categories'] ALTER TABLE wp_categories ADD COLUMN links_private tinyint(1) NOT NULL default '0' }}} There were also a lot of secondary errors due to the above failed commands. However, the upgrade.php script still claimed that all was well: {{{ There's actually only one step. So if you see this, you're done. Have fun! }}} It would be more helpful if WP would detect the MySQL errors and actually say that something went wrong and must be fixed, instead of saying that all is well even though there were heaps of errors. This only happens once: If I run the upgrade.php script again, it just says 'all is well' without any errors, so the MySQL commands that would fail are not run again. However, the database is still broken. It would be better if WP discovered that an upgrade failed, and set a flag somewhere that said 'this upgrade must be run again'. See also http://wordpress.org/support/topic/111398?replies=2 ",enhancement,closed,normal,,Upgrade/Install,2.1.2,normal,wontfix,close,,