WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 2 months ago

#40315 closed defect (bug) (fixed)

Design issue in Feature Filter Tab of Appearance > Theme

Reported by: nitin kevadiya Owned by: afercia
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch has-screenshots
Focuses: ui Cc:

Description

When I go to Appearance > Themes Then Feature Filter tab or Favorites Tab then content box below that both tabs are not aligned.

Steps : Appearance > Themes > Favorites/Feature Filter tab. See content box below search button.

Attachments (6)

error2.png (112.0 KB) - added by nitin kevadiya 4 months ago.
Not Aligned.
error1.png (29.9 KB) - added by nitin kevadiya 4 months ago.
Not Aligned.
40315.patch (424 bytes) - added by darshan02 4 months ago.
issue resolved in this patch
40315.png (55.3 KB) - added by darshan02 4 months ago.
here is screenshot resolved issue
Add Themes ‹ wordpress core Just another WordPress site — WordPress.png (135.2 KB) - added by mp518 2 months ago.
wordpress 4.8 beta
40315.diff (843 bytes) - added by afercia 2 months ago.

Download all attachments as: .zip

Change History (15)

@nitin kevadiya
4 months ago

Not Aligned.

@nitin kevadiya
4 months ago

Not Aligned.

#1 @darshan02
4 months ago

  • Keywords has-patch added

Hello,

yes @nitin kevadiya you are right there is problem in wp-admin/css/common.css some css need to insert.i have added patch and this problem is resolved.

Thanks

@darshan02
4 months ago

issue resolved in this patch

@darshan02
4 months ago

here is screenshot resolved issue

#2 @SergeyBiryukov
4 months ago

  • Component changed from Administration to Themes
  • Focuses ui added

#3 @darshan02
3 months ago

Hello @SergeyBiryukov,

This issue still remains in wp 4.7.4 new version.I am waiting for milestone please review patch.

Thanks

Last edited 3 months ago by darshan02 (previous) (diff)

#4 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 4.8

This ticket was mentioned in Slack in #core by mahesh.prajapati. View the logs.


2 months ago

#6 @mp518
2 months ago

  • Keywords has-screenshots has-unit-tests added

I have tested 40315.patch and this is working well in wordpress 4.8 beta 1.

#7 @afercia
2 months ago

  • Keywords has-unit-tests removed
  • Owner set to afercia
  • Status changed from new to assigned
  • Version 4.7.3 deleted

nitin kevadiya, darshan02, mp518 thanks for the ticket, patch, and testing! The current patch fixes the issue on the right side but also makes the space on the left side a bit too big. .wp-filter .favorites-form needs to be fixed too.

#8 @afercia
2 months ago

40315.diff makes .favorites-form and .filter-drawer behave the same and adjusts the negative margin on the right. Removes width: 100% otherwise negative margins don't work as expected.

@afercia
2 months ago

#9 @afercia
2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 40797:

Themes: Improve the theme installer Favorites and Feature Filter tabs alignment.

Props nitin kevadiya, darshan02, mp518.
Fixes #40315.

Note: See TracTickets for help on using tickets.