Update name in toolbar when changing user display name

[swissspidy]

When changing the site name in Settings -> General, the name displayed in the toolbar changes automatically using JavaScript. When changing your name in your user profile, the display name choice updates as well (#5691).

Now, I think we should also update the toolbar when changing the display name. So, when I change my display name from "John" to "John Doe", the toolbar should change from "Howdy, John" to "Howdy, John Doe". Currently, this only happens after saving.

[menakas]

Added javascript to change Greeting name when display name dropdown is changed.

[lukecavanagh]

40342.patch​ The patch applies cleanly and fixes that issue.

[swissspidy]

It makes more sense to put this into user-profile.js in my opinion. Also, although I like using plain old JavaScript, I think we can use the JQuery functions instead of innerHTML.

[maguiar]

Moves JS to user-profile.js and uses jQuery

[maguiar]

Agree with @swissspidy, new patch moves the logic to user-profile.js and uses jQuery since it's already there

[swissspidy]

Yeah that's much more like what I had anticipated.

The only drawback to 40342.diff​ is that it also changes the name when you're editing the profile of someone who's got the same name as you, because it's just a simple search & replace.

[menakas]

Added a check for current user id and the user id of profile that is being edited

[lukecavanagh]

40342.2.patch​ Applies cleanly.

[adamsilverstein]

@maguiar & @menakas Thanks for your patch here!

I'm a little concerned by the use of .html() here because its content gets evaluated presenting a potential XSS vector. testing this I wasn’t able to exploit, however it would be better to replace only the inner name part with .text() which isn't evaluated, do you think that is possible? we can add an additional span wrapper in the html if you need a way to target the inner name part.

[maguiar]

Replaces .html references for .text, add a span.display_name to toolbar howdy

[maguiar]

Added 40342.2.diff​ which adds a span class to the howdy message, accounting for translations. Replaced .html method with .text and removed unnecessary code from the JS that is handled by the new span.

[adamsilverstein]

In 40657:

Users: Update name in toolbar when changing user display name.

When changing the user name in Users -> Your Profile, update the name displayed in the toolbar dynamically using JavaScript.

Props menakas, lukecavanagh, maguiar.
Fixes #40342.