WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 5 months ago

#40405 closed defect (bug) (fixed)

Customize: IE9 errors when attempting to generate changeset parameter

Reported by: westonruter Owned by: westonruter
Milestone: 4.7.4 Priority: normal
Severity: normal Version: 4.7.3
Component: Customize Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

The change [39686] for #39227 broke the customizer in IE9 since it doesn't properly account for the availability of history.replaceState.

Attachments (1)

40405.0.diff (1.1 KB) - added by westonruter 6 months ago.

Download all attachments as: .zip

Change History (8)

@westonruter
6 months ago

#1 @westonruter
6 months ago

  • Keywords has-patch commit added
  • Version set to 4.7.3

#2 @swissspidy
6 months ago

  • Keywords has-patch commit removed

#3 @swissspidy
6 months ago

  • Keywords has-patch commit added

Whoops, sorry. Removed by accident.

#4 @timmydcrawford
6 months ago

Steps to see the bug using IE9:

  • Open the customizer
  • Navigate to widgets and change the title of a widget
  • Click outside of the title and note the error will be shown in the console

https://cloud.githubusercontent.com/assets/22080/24881448/a39ae402-1df2-11e7-872d-8772464d527a.png

I tested out the same flow with this patch and all is working well. Thanks for the quick fix @westonruter !

#5 @westonruter
6 months ago

  • Owner set to westonruter
  • Resolution set to fixed
  • Status changed from new to closed

In 40405:

Customize: Verify availability of history.replaceState (in IE9) before attempting to populate changeset_uuid parameter.

Props westonruter, timmydcrawford for testing.
Amends [39686].
See #39227.
Fixes #40405.

#6 @westonruter
6 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening for 4.7.4

#7 @swissspidy
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 40420:

Customize: Verify availability of history.replaceState (in IE9) before attempting to populate changeset_uuid parameter.

Props westonruter, timmydcrawford for testing.
Amends [39686].
See #39227.
Fixes #40405.

Merges[40405] to the 4.7 branch.

Note: See TracTickets for help on using tickets.