Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#40430 closed enhancement (fixed)

Site Icons: Improve copy

Reported by: melchoyce's profile melchoyce Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Customize Keywords: good-first-bug has-patch dev-feedback
Focuses: ui Cc:

Description

The Site Icon copy is a little confusing and lacks context. @michelleweber has proposed improved copy to explain the Site Icon feature:

Site Icons are what you see in browser tabs, bookmark bars, and in the WordPress app. Upload one here!

Site Icons should be square, and at least 512px by 512px.

Attaching a mockup.

Attachments (5)

site-icon-copy.png (55.7 KB) - added by melchoyce 6 years ago.
40430.patch (860 bytes) - added by menakas 6 years ago.
Site Icon copy changed as per suggestion
40430.diff (860 bytes) - added by menakas 6 years ago.
Corrected: "within the WordPress mobile app"
Screen Shot 2017-09-28 at 9.08.09 PM.png (53.6 KB) - added by melchoyce 6 years ago.
40430.2.diff (992 bytes) - added by dlh 6 years ago.

Download all attachments as: .zip

Change History (27)

#1 @westonruter
6 years ago

  • Keywords needs-patch good-first-bug added

@menakas
6 years ago

Site Icon copy changed as per suggestion

#2 @menakas
6 years ago

  • Keywords has-patch added; needs-patch removed

#3 @lukecavanagh
6 years ago

40430.patch Patch applies cleanly and looks fine.

#4 @SergeyBiryukov
6 years ago

Current text, introduced in [33154]:

The Site Icon is used as a browser and app icon for your site. Icons must be square, and at least 512 pixels wide and tall.

"App icon" refers to iOS app icons and Windows tile icons, see the discussion in #16434.

I'm not sure what "the WordPress app" in the updated text refers to :)

Last edited 6 years ago by SergeyBiryukov (previous) (diff)

#6 follow-up: @melchoyce
6 years ago

"The WordPress apps" means the WordPress mobile apps: https://wordpress.org/mobile/

#7 in reply to: ↑ 6 ; follow-up: @SergeyBiryukov
6 years ago

Replying to melchoyce:

"The WordPress apps" means the WordPress mobile apps: https://wordpress.org/mobile/

Yeah, but the original meaning was that Site Icon is displayed when the site is added to home screen in iOS or Android or to the Start menu in Windows. I don't see how the WordPress mobile apps are relevant here :)

#8 in reply to: ↑ 7 @melchoyce
6 years ago

Replying to SergeyBiryukov:

Replying to melchoyce:

"The WordPress apps" means the WordPress mobile apps: https://wordpress.org/mobile/

Yeah, but the original meaning was that Site Icon is displayed when the site is added to home screen in iOS or Android or to the Start menu in Windows. I don't see how the WordPress mobile apps are relevant here :)

Your favicon (also known as "blavatar" sometimes) is shown in the mobile apps to represent your site, which is why it's relevant.

Pinging @michelleweber for feedback re: app icon meaning something else.

Last edited 6 years ago by melchoyce (previous) (diff)

#9 follow-up: @lukecavanagh
6 years ago

Would it not be possible to detect for Android or iOS and if using the mobile app, then display that specific wording with WordPress app wording?

#10 in reply to: ↑ 9 ; follow-up: @SergeyBiryukov
6 years ago

Replying to lukecavanagh:

Would it not be possible to detect for Android or iOS and if using the mobile app, then display that specific wording with WordPress app wording?

The text is displayed in the customizer, but the site admin's browser is not relevant here, it's about other users adding the site to the home screen on their mobile devices as a quick bookmark with the site icon (called "app icon" in the original text).

#11 in reply to: ↑ 10 @SergeyBiryukov
6 years ago

Replying to SergeyBiryukov:

it's about other users adding the site to the home screen on their mobile devices

https://www.howtogeek.com/196087/how-to-add-websites-to-the-home-screen-on-any-smartphone-or-tablet/

#12 @michelleweber
6 years ago

Sorry to have missed your ping, @melchoyce!

It actually didn't occur to me that "the WordPress app" could be misconstrued in this context, but for added clarity, feel free to change the text to "within the WordPress mobile app." I think that speaks to the issue here?

#13 @DrewAPicture
6 years ago

  • Owner set to menakas
  • Status changed from new to assigned

Assigning ownership to mark the good-first-bug as "claimed".

@menakas
6 years ago

Corrected: "within the WordPress mobile app"

#14 @menakas
6 years ago

  • Keywords reporter-feedback added

#15 @melchoyce
6 years ago

  • Keywords dev-feedback added; reporter-feedback removed
  • Milestone changed from Awaiting Review to 4.9

Hi @menakas! Thanks for patching this. I noticed two things:

  1. The second paragraph ("Site Icons should be square...") should be a new paragraph, instead of using a <br /> tag.
  2. For some reason, the icon size is showing up as 0.

This ticket was mentioned in Slack in #core-customize by melchoyce. View the logs.


6 years ago

@dlh
6 years ago

#17 @dlh
6 years ago

In 40430.2.diff:

  • Split the sentences into paragraphs.
  • Remove the comma from the second sentence because it isn't separating complete sentences (at least, I think that's correct).
  • Move "pixels" back into the translatable string for consistency with the Custom Header control description.

I'm seeing conflicting precedent about whether &times; should also be in the translated string, but I left it out so that the <strong> tags could be more-easily kept out of the string.

#18 follow-up: @melchoyce
6 years ago

Just realized the first paragraph should probably not be italic, since it's the description. The second one can remain italicized. Otherwise, looks good to me — thanks @dlh.

@SergeyBiryukov Would you be able to review this by any chance?

#19 @SergeyBiryukov
6 years ago

  • Owner changed from menakas to SergeyBiryukov
  • Status changed from assigned to reviewing

This ticket was mentioned in Slack in #core-customize by sergey. View the logs.


6 years ago

#21 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 41749:

Customize: Improve the wording for Site Icon control intro.

Props michelleweber, dlh, menakas, melchoyce.
Fixes #40430.

#22 in reply to: ↑ 18 @dlh
6 years ago

Replying to melchoyce:

Just realized the first paragraph should probably not be italic, since it's the description. The second one can remain italicized. Otherwise, looks good to me — thanks @dlh.

I'm sorry, I'm not sure I follow. I thought italics were part of the default styles for control descriptions?

Note: See TracTickets for help on using tickets.