Site Icons: Improve copy

[melchoyce]

The Site Icon copy is a little confusing and lacks context. @michelleweber has proposed improved copy to explain the Site Icon feature:

Site Icons are what you see in browser tabs, bookmark bars, and in the WordPress app. Upload one here!

Site Icons should be square, and at least 512px by 512px.

Attaching a mockup.

[menakas]

Site Icon copy changed as per suggestion

[lukecavanagh]

40430.patch​ Patch applies cleanly and looks fine.

[SergeyBiryukov]

Current text, introduced in [33154]:

The Site Icon is used as a browser and app icon for your site. Icons must be square, and at least 512 pixels wide and tall.

"App icon" refers to iOS app icons and Windows tile icons, see the discussion in #16434.

I'm not sure what "WordPress app" in the updated text refers to :)

[lukecavanagh]

I think the WordPress app means, Calypso.

​https://github.com/Automattic/wp-calypso/issues/37

[melchoyce]

"The WordPress apps" means the WordPress mobile apps: ​https://wordpress.org/mobile/

[SergeyBiryukov]

Replying to melchoyce:

"The WordPress apps" means the WordPress mobile apps: ​https://wordpress.org/mobile/

Yeah, but the original meaning was that Site Icon is displayed when the site is added to home screen in iOS or Android or to the Start menu in Windows. I don't see how the WordPress mobile apps are relevant here :)

[melchoyce]

Replying to SergeyBiryukov:

Replying to melchoyce:

"The WordPress apps" means the WordPress mobile apps: ​https://wordpress.org/mobile/

Yeah, but the original meaning was that Site Icon is displayed when the site is added to home screen in iOS or Android or to the Start menu in Windows. I don't see how the WordPress mobile apps are relevant here :)

Your favicon (also known as "blavatar" sometimes) is shown in the mobile apps to represent your site, which is why it's relevant.

Pinging @michelleweber for feedback re: app icon meaning something else.

[lukecavanagh]

Would it not be possible to detect for Android or iOS and if using the mobile app, then display that specific wording with WordPress app wording?

[SergeyBiryukov]

Replying to lukecavanagh:

Would it not be possible to detect for Android or iOS and if using the mobile app, then display that specific wording with WordPress app wording?

The text is displayed in the customizer, but the site admin's browser is not relevant here, it's about other users adding the site to the home screen on their mobile devices as a quick bookmark with the site icon (called "app icon" in the original text).

[SergeyBiryukov]

Replying to SergeyBiryukov:

it's about other users adding the site to the home screen on their mobile devices

​https://www.howtogeek.com/196087/how-to-add-websites-to-the-home-screen-on-any-smartphone-or-tablet/

[michelleweber]

Sorry to have missed your ping, @melchoyce!

It actually didn't occur to me that "the WordPress app" could be misconstrued in this context, but for added clarity, feel free to change the text to "within the WordPress mobile app." I think that speaks to the issue here?

[DrewAPicture]

Assigning ownership to mark the good-first-bug as "claimed".

[menakas]

Corrected: "within the WordPress mobile app"

[melchoyce]

Hi @menakas! Thanks for patching this. I noticed two things:

1. The second paragraph ("Site Icons should be square...") should be a new paragraph, instead of using a <br /> tag.
2. For some reason, the icon size is showing up as 0.

[dlh]

In 40430.2.diff​:

• Split the sentences into paragraphs.

• Remove the comma from the second sentence because it isn't separating complete sentences (at least, I think that's correct).

• Move "pixels" back into the translatable string for consistency with the Custom Header control description.

I'm seeing conflicting precedent about whether × should also be in the translated string, but I left it out so that the <strong> tags could be more-easily kept out of the string.

[melchoyce]

Just realized the first paragraph should probably not be italic, since it's the description. The second one can remain italicized. Otherwise, looks good to me — thanks @dlh.

@SergeyBiryukov Would you be able to review this by any chance?

[SergeyBiryukov]

In 41749:

Customize: Improve the wording for Site Icon control intro.

Props michelleweber, dlh, menakas, melchoyce.
Fixes #40430.

[dlh]

Replying to melchoyce:

Just realized the first paragraph should probably not be italic, since it's the description. The second one can remain italicized. Otherwise, looks good to me — thanks @dlh.

I'm sorry, I'm not sure I follow. I thought italics were part of the default styles for control descriptions?