WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #40439, comment 36


Ignore:
Timestamp:
06/06/2019 11:28:23 PM (6 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #40439, comment 36

    v1 v2  
    44- Review, improve, account for edge cases in `wp_get_missing_image_subsizes()`, `wp_get_defined_image_subsizes()`, and `wp_create_image_subsizes()`.
    55- Fix the `$duplicate` test when creating new sub-size in both `WP_Image_Editor_Imagick` and `WP_Image_Editor_GD`. It only checks whether the just resized image matches the source image.
    6 - Add fallback when a plugin extends `WP_Image_Editor` and doesn't have the new `make_subsize()` method that returns the image meta value after each sub-size is created.
     6- Add fallback when a plugin extends `WP_Image_Editor` and doesn't have the new `make_subsize()` method that returns the image size (for including in the meta) after each sub-size is created.
    77
    88There are also some unrelated WPCS fixes in the patch.
    99
    1010This seems to work well here. Please get the [https://gist.github.com/azaozz/91101d686127137b0f5b850f0d269972 testing plugin] and give it a go :)
     11
     12The testing plugin shows the image meta on the Media screen, list mode (switch modes with the buttons at the top/left of the screen). It adds few large image sizes. After it is enabled you should see these new sizes listed as missing for all images that are large enough to support them. When all files for an uploaded image are present, it would let you selectively delete a few, and then re-create them.
     13
     14After testing it would be good to check the uploads directory where the uploaded image is, to ensure all sizes were created properly.