WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#40442 closed task (blessed) (fixed)

Widgets: Rename "Custom Menu" widget to "Menu"

Reported by: melchoyce Owned by: westonruter
Milestone: 4.9 Priority: lowest
Severity: normal Version:
Component: Widgets Keywords: has-patch
Focuses: Cc:
PR Number:

Description

The "Custom" part of the widget name is a vestigial label from back when non-custom menus were more of a thing. I think at this point, custom menus are pretty much the default way of making a menu. We could probably drop "Custom" from the widget name.

Attachments (4)

––enhancement-40442.diff (854 bytes) - added by gk.loveweb 3 years ago.
Changed the text "Custom Menu" To "Menu"
Menu Widget.png (13.3 KB) - added by lukecavanagh 3 years ago.
Menu Widget
enhancement-40442.1.diff (5.0 KB) - added by ajayghaghretiya1 2 years ago.
40442.diff (11.8 KB) - added by ChrisHardie 2 years ago.
Refreshed patch for Custom Menu -> Navigation Menu change

Download all attachments as: .zip

Change History (21)

#1 @joyously
3 years ago

From the perspective of calling wp_nav_menu(), there is the custom menu that you specify you want to show and there is the fallback menu. In the widget, there is only a choice of Custom menu. It won't show you the fallback. So in a way, Custom Menu makes sense. The default for the fallback is Pages, which is a different widget.

@gk.loveweb
3 years ago

Changed the text "Custom Menu" To "Menu"

#2 @gk.loveweb
3 years ago

Hello @melchoyce Kindly check my patch file.

#3 @lukecavanagh
3 years ago

––enhancement-40442.diff Applies cleanly and seems to fix that issue.

@lukecavanagh
3 years ago

Menu Widget

#4 follow-up: @gk.loveweb
3 years ago

@lukecavanagh Thanks for testing the patch. waiting for the response of @melchoyce :)

#5 in reply to: ↑ 4 @melchoyce
3 years ago

Replying to gk.loveweb:

Thanks for testing the patch. waiting for the response of @melchoyce :)

Thanks for the patch, @gk.loveweb. :) Hoping to get some more opinions before we make a decision.

#6 @karmatosed
3 years ago

+1 for this. Custom menu makes no sense to users.

This ticket was mentioned in Slack in #core by gkloveweb. View the logs.


3 years ago

#9 follow-up: @melchoyce
2 years ago

Would "Navigation Menu" be more clear?

#10 in reply to: ↑ 9 @ajayghaghretiya1
2 years ago

Replying to melchoyce:

Would "Navigation Menu" be more clear?

Added patch with the navigation please check it. if any other changes required.

enhancement-40442.1.diff

#11 @DrewAPicture
2 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core by ajayghaghretiya. View the logs.


2 years ago

#13 @melchoyce
2 years ago

  • Keywords needs-refresh added

Getting some errors now when I try to apply the patch:

patching file src/wp-includes/widgets/class-wp-nav-menu-widget.php
Hunk #2 FAILED at 17.
Hunk #3 succeeded at 59 (offset -2 lines).
Hunk #4 succeeded at 80 with fuzz 1 (offset -2 lines).
Hunk #5 succeeded at 101 with fuzz 1 (offset -3 lines).
1 out of 5 hunks FAILED -- saving rejects to file src/wp-includes/widgets/class-wp-nav-menu-widget.php.rej
Last edited 2 years ago by melchoyce (previous) (diff)

@ChrisHardie
2 years ago

Refreshed patch for Custom Menu -> Navigation Menu change

#14 @ChrisHardie
2 years ago

  • Keywords needs-refresh removed

Submitted patch brings @ajayghaghretiya1's changes current and touches a few more spots where the old label was still in use.

#15 @melchoyce
2 years ago

  • Milestone changed from Awaiting Review to 4.9
  • Type changed from enhancement to task (blessed)

#16 @melchoyce
2 years ago

  • Owner set to westonruter
  • Status changed from new to assigned

#17 @westonruter
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 41868:

Widgets: Rename "Custom Menu" widget to "Navigation Menu".

Props gk.loveweb, ChrisHardie, ajayghaghretiya1, melchoyce.
Fixes #40442.

Note: See TracTickets for help on using tickets.