Widgets: Rename "Custom Menu" widget to "Menu"

[melchoyce]

The "Custom" part of the widget name is a vestigial label from back when non-custom menus were more of a thing. I think at this point, custom menus are pretty much the default way of making a menu. We could probably drop "Custom" from the widget name.

[joyously]

From the perspective of calling wp_nav_menu(), there is the custom menu that you specify you want to show and there is the fallback menu. In the widget, there is only a choice of Custom menu. It won't show you the fallback. So in a way, Custom Menu makes sense. The default for the fallback is Pages, which is a different widget.

[gk.loveweb]

Changed the text "Custom Menu" To "Menu"

[gk.loveweb]

Hello @melchoyce Kindly check my patch file.

[lukecavanagh]

––enhancement-40442.diff​ Applies cleanly and seems to fix that issue.

[lukecavanagh]

Menu Widget

[gk.loveweb]

@lukecavanagh Thanks for testing the patch. waiting for the response of @melchoyce :)

[melchoyce]

Replying to gk.loveweb:

Thanks for testing the patch. waiting for the response of @melchoyce :)

Thanks for the patch, @gk.loveweb. :) Hoping to get some more opinions before we make a decision.

[karmatosed]

+1 for this. Custom menu makes no sense to users.

[Presskopp]

We should not forget to adjust the string here:

https://core.trac.wordpress.org/browser/trunk/src/wp-admin/nav-menus.php?marks=522#L522

[melchoyce]

Would "Navigation Menu" be more clear?

[ajayghaghretiya1]

Replying to melchoyce:

Would "Navigation Menu" be more clear?

Added patch with the navigation please check it. if any other changes required.

enhancement-40442.1.diff

[melchoyce]

Getting some errors now when I try to apply the patch:

patching file src/wp-includes/widgets/class-wp-nav-menu-widget.php
Hunk #2 FAILED at 17.
Hunk #3 succeeded at 59 (offset -2 lines).
Hunk #4 succeeded at 80 with fuzz 1 (offset -2 lines).
Hunk #5 succeeded at 101 with fuzz 1 (offset -3 lines).
1 out of 5 hunks FAILED -- saving rejects to file src/wp-includes/widgets/class-wp-nav-menu-widget.php.rej

[ChrisHardie]

Refreshed patch for Custom Menu -> Navigation Menu change

[ChrisHardie]

Submitted patch brings @ajayghaghretiya1's changes current and touches a few more spots where the old label was still in use.

[westonruter]

In 41868:

Widgets: Rename "Custom Menu" widget to "Navigation Menu".

Props gk.loveweb, ChrisHardie, ajayghaghretiya1, melchoyce.
Fixes #40442.