WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 2 months ago

#40457 closed defect (bug) (duplicate)

Twenty Seventeen: Lots of space under blog post titles with one column layout on front page

Reported by: laurelfulford Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

I noticed this while reviewing #40264:

When you set the blog posts page as one of the panels on the front page, and set the site to use the one column layout, there's a lot of space underneath the blog post titles:

https://cldup.com/3gPimIoCO7-3000x3000.png

Steps to reproduce:

  1. On a site running Twenty Seventeen, set up a static front page
  2. Pick your blog posts page as one of the panels
  3. Set the theme to use the one column layout.

The spacing should actually be closer to what it's like in the two column layout:

https://cldup.com/gKID-eGN5u-3000x3000.png

Will follow up with a patch shortly.

Attachments (1)

40457.patch (456 bytes) - added by laurelfulford 5 years ago.
Makes blog header margin more specific on front page when layout is set to one column.

Download all attachments as: .zip

Change History (4)

@laurelfulford
5 years ago

Makes blog header margin more specific on front page when layout is set to one column.

#1 @laurelfulford
5 years ago

  • Keywords has-patch added

#2 @laurelfulford
3 years ago

  • Keywords needs-testing added

#3 @sabernhardt
2 months ago

  • Keywords needs-testing removed
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

This was opened first and I like your patch, but #43628 has more discussion. So I'll close this and upload the patch to that ticket.

Note: See TracTickets for help on using tickets.