Context Navigation

← Previous Ticket
Next Ticket →

#4047 closed defect (bug) (fixed)

pointless use of preg_match in get_plugins()

Reported by:	m0n5t3r	Owned by:	rob1n
Priority:	low	Milestone:	2.2
Component:	Optimization	Version:
Severity:	normal	Keywords:
Cc:		Focuses:

Description

... patch attached

Attachments (2)

get_plugins_no_preg_match.diff (1010 bytes ) - added by m0n5t3r 19 years ago.
4047.diff (1.0 KB ) - added by rob1n 19 years ago.

Download all attachments as: .zip

Change History (7)

@m0n5t3r
19 years ago

Attachment get_plugins_no_preg_match.diff added

#1 @rob1n
19 years ago

Component Administration → Optimization
Keywords has-patch removed
Milestone 2.3 → 2.2
Owner changed from anonymous to rob1n
Status new → assigned

The point of the preg_match is to grab any filename that STARTS with ".". New patch coming up. But I agree -- pointless use of preg_match. WP's code has quite a few of those :\.

#2 @rob1n
19 years ago

Sorry, I'm mistaken. That just matches ., .. or ......... I think we should omit directories that start with ., though. Such as .svn, etc.

@rob1n
19 years ago

Attachment 4047.diff added

#3 @rob1n
19 years ago

Status assigned → new

#4 @markjaquith
19 years ago

+1 to rob1n's patch

#5 @rob1n
19 years ago

Resolution → fixed
Status new → closed

(In [5152]) Take out useless preg_match()'s and ignore directories starting with ".". Props m0n5t3r. fixes #4047

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#4047 closed defect (bug) (fixed)

pointless use of preg_match in get_plugins()

Description

Attachments (2)

Change History (7)

@m0n5t3r 19 years ago

#1 @rob1n 19 years ago

#2 @rob1n 19 years ago

@rob1n 19 years ago

#3 @rob1n 19 years ago

#4 @markjaquith 19 years ago

#5 @rob1n 19 years ago