Make WordPress Core

Opened 4 years ago

Last modified 3 years ago

#40486 new enhancement

Twenty Seventeen: Logic for translated strings in connection with Screen Reader text can be improved

Reported by: Presskopp Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: Cc:


There are 2 strings including:

screen-reader-text"> "%s"


Continue reading<span class="screen-reader-text"> "%s"</span>



Edit<span class="screen-reader-text"> "%s"</span>

In german (as an example, I assume this happens too in other languages) the syntax for 1) needs to be reversed like that:

<span class="screen-reader-text">"%s"</span> weiterlesen

2) gets:

<span class="screen-reader-text">&#8222;%s&#8220;</span> bearbeiten

which is correct for Screen Reader Users, but it should rather be capitalized in both cases so the button text doesn't start lowercase, see screenshot.


We could now capitalize the strings in translation, but there must be a better solution!?

Yes, the quotation marks in our translation also needs a little attention, but that's not part of the ticket ;-)

Attachments (1)

pasted_image_at_2017_04_19_04_42_pm.png (101.7 KB) - added by Presskopp 4 years ago.

Download all attachments as: .zip

Change History (3)

#1 @Presskopp
4 years ago

  • Component changed from I18N to Bundled Theme

#2 @joyously
3 years ago

Would this fix it?

the_content( sprintf(
  /* translators: %s: Name of current post for Continue link, only visible to screen readers, with space before and after */
  esc_html__( 'Continue reading%s', 'twentyseventeen' ),
    '<span class="screen-reader-text"> "' . wp_strip_all_tags( get_the_title() ) . '" </span>'
) );


  /* translators: %s: Name of current post for edit link, only visible to screen readers, with space before and after */
    esc_html__( 'Edit%s', 'twentyseventeen' ),
      '<span class="screen-reader-text"> "' . wp_strip_all_tags( get_the_title() ) . '" </span>'
  ' <span class="edit-link">',

It doesn't address the capitalization problem though.

Note: See TracTickets for help on using tickets.