WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 9 months ago

#40493 new enhancement

On the Edit User Profile, open the "You can change your profile picture on Gravatar." link in a new window

Reported by: ashokrane Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Users Keywords: target-blank needs-patch
Focuses: accessibility Cc:
PR Number:

Description

On the Edit User Profile, open the "You can change your profile picture on Gravatar." link in a new window.
Reason being that otherwise it causes the user to loose any data that they have edited in the form, but not yet saved.

Change History (6)

#1 @swissspidy
3 years ago

  • Keywords target-blank added

Hey there,

Thanks for your report and welcome!

As per #23432, we rather strive to remove usage of target="_blank". As for losing data, the browser should warn you when you're about to leave a page without having saved the form.

See https://core.trac.wordpress.org/query?keywords=~target-blank for related tickets.

#2 @ashokrane
3 years ago

Thanks @swissspidy. I agree. The browser didn't throw any warning when I have unsaved data & when I clicked on the "Gravatar" text. Doing that would be a better approach then opening in a new window (after going through other related tickets).

#3 @ajmaurya
2 years ago

  • Keywords reporter-feedback added

Hey i also once had the same thought on opening the Gravatar link in a new window, but after reading this it totally makes much more sense now.

#4 @afercia
9 months ago

  • Focuses accessibility added

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


9 months ago

#6 @afercia
9 months ago

  • Keywords needs-patch added; reporter-feedback removed
  • Milestone changed from Awaiting Review to Future Release
  • Version 4.7.3 deleted

Discussed during today's accessibility bug-scrub, agreed this form would need the JS confirm to warn users they can lose data when navigating away. No target _blank please :)

Note: See TracTickets for help on using tickets.