Use get_network_option in wpmu_create_blog

[spacedmonkey]

In wpmu_create_blog, you can pass a site id, however this is not passed to the following file

'WPLANG' => get_site_option( 'WPLANG' )

[flixos90]

The actual change in the patch looks good.

Changing the variable name from $site_id to $network_id is not really a practice we've been following, but recent efforts in ensuring consistency with our coding standards give me a feeling that this becomes more acceptable. I'm not entirely sure the name change belongs in here, but I'm not opposed either.

A unit test will be necessary though.

[spacedmonkey]

Tests added

[DrewAPicture]

@spacedmonkey Looks pretty good.

Now that we're (finally!) renaming $site_id to $network_id in a couple places, we should write more useful descriptions where they're referenced in DocBlocks. "Optional. Only relevant on multi-network installs." has always been pretty meh :-)

[flixos90]

@DrewAPicture I take that as a confirmation that changing variable names like that to follow current naming conventions is acceptable. :)

[DrewAPicture]

Replying to flixos90:

@DrewAPicture I take that as a confirmation that changing variable names like that to follow current naming conventions is acceptable. :)

I don't have a problem with it, as long as it's improving the ability for the code to better self-dccument. The $site_id vs $network_id thing is super confusing in a bunch of places – it would be good to provide some clarity here and elsewhere.

[flixos90]

40503.3.diff​ is a tiny update on the previous patch.

Having a second look, I think it doesn't make much sense to change the $site_id to $network_id here, since there is still $blog_id around, and having a function with $blog_id and $network_id is worse in my opinion. It would also be strange to rename $blog_id to $site_id since the function would still have "blog" in the name.

The rename here is not worth the changeset clutter, although I generally like the idea of doing such changes. Given that we're working on a better implementation of a similar method anyway (see #40364), I think we can leave things as they are for now.

I only changed a bit of documentation to use the correct "Site" and "Network" terms there.

[flixos90]

In 41058:

Multisite: Use get_network_option() for language in wpmu_create_blog().

Before this changeset, the language of a new site would always result in the language of the current network, regardless of the $site_id parameter passed that actually determines the network for the site. Now the correct WPLANG value is used in such cases.

Alongside this change, a few minor documentation changes around the function have been made to account for the current naming conventions of sites and networks.

Props spacedmonkey.
Fixes #40503.