WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#40507 closed defect (bug) (fixed)

Customize: Hide Controls link is itself hidden in IE

Reported by: westonruter's profile westonruter Owned by: westonruter's profile westonruter
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.7
Component: Customize Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

As discovered in #32296:

I will note in IE that, with and without the patch, the Hide Controls link is… hidden. This seems to be due to the z-index: -1 introduced in r39214 for #38762.

Screenshots in ​https://cloudup.com/cdo2nHseiyD

Attachments (1)

40507.0.diff​ (3.2 KB) - added by westonruter 7 years ago.
via @timmydcrawford in https://core.trac.wordpress.org/attachment/ticket/32296/32296-e.diff

Download all attachments as: .zip

Change History (7)

@westonruter
7 years ago

via @timmydcrawford in https://core.trac.wordpress.org/attachment/ticket/32296/32296-e.diff

#1 @westonruter
7 years ago

  • Keywords commit added

In 40507.0.diff​ via @timmydcrawford:

I have added a proposed fix for that. I opted to change the order of the elements in the DOM to allow the background on .devices to stack naturally... also had to add a position attribute to that class get the background/fade to function properly which resulted in adding the wrapper div.

You can see the screenshots above of this diff in IE9 with a normal English translation, and a longer string.

#2 @westonruter
7 years ago

  • Owner set to westonruter
  • Resolution set to fixed
  • Status changed from new to closed

In 40510:

Customize: Fix visibility of "Hide Controls" link in IE.

Amends [39214].
Props timmydcrawford.
See #32296, #38762.
Fixes #40507.

#3 @westonruter
7 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening for consideration in 4.7.5

This ticket was mentioned in ​Slack in #core by desrosj. ​View the logs.
7 years ago

#5 @desrosj
7 years ago

  • Milestone changed from 4.7.5 to 4.8

@westonruter anything left keeping this from being closed out?

#6 @westonruter
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.