WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #40510, comment 5


Ignore:
Timestamp:
03/30/2018 02:04:20 PM (3 years ago)
Author:
adamsilverstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #40510, comment 5

    initial v1  
    1 This looks good @flixos90!
     1This looks good @flixos90! Tested with the JS client and I see all of the expected headers and pagination functionality.
    22
    3 In [attachment:40510.2.diff] I added a cast to (int) for `$request['page'];`use and update the fixtures. (`phpunit --group=restapi-jsclient` or `grunt precommit` generates this file). Some tests to validate the new features would be nice.
     3In [attachment:40510.2.diff] I added a cast to (int) for `$request['page'];`use and update the fixtures. (`phpunit --group=restapi-jsclient` or `grunt precommit` generates this file). Some tests to validate all of the new features would be nice.