Opened 9 years ago
Closed 9 years ago
#40516 closed defect (bug) (fixed)
Twenty Seventeen: Remove uneccessary return statement in twentyseventeen_edit_link()
| Reported by: | truongwp | Owned by: | obenland |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.8 |
| Component: | Bundled Theme | Version: | 4.7 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | template |
Description
I think that the return statement in twentyseventeen_edit_link() function is not neccessary because the edit_post_link() function always returns null.
Attachments (1)
Change History (11)
#1
@
9 years ago
- Component Themes → Bundled Theme
- Summary Remove uneccessary return statement in twentyseventeen_edit_link() → Twenty Seventeen: Remove uneccessary return statement in twentyseventeen_edit_link()
#2
@
9 years ago
- Keywords has-patch added
- Milestone Awaiting Review → 4.7.5
- Type enhancement → defect (bug)
- Version trunk → 4.7
#3
follow-up:
↓ 4
@
9 years ago
what about the line
twentyseventeen_edit_link( get_the_ID() );
in:
content-front-page-panels.php content-front-page.php content-page.php
?
#5
@
9 years ago
40516.diff Applies cleanly.
This ticket was mentioned in Slack in #core by desrosj. View the logs.
9 years ago
This ticket was mentioned in Slack in #core by obenland. View the logs.
9 years ago
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Yep, actually
edit_post_link()echoes the link and doesn't return anything so the implementation here doesn't look correct to me. Thanks @truongwp !