Opened 8 years ago
Closed 8 years ago
#40516 closed defect (bug) (fixed)
Twenty Seventeen: Remove uneccessary return statement in twentyseventeen_edit_link()
Reported by: | truongwp | Owned by: | obenland |
---|---|---|---|
Milestone: | 4.8 | Priority: | normal |
Severity: | normal | Version: | 4.7 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | template | Cc: |
Description
I think that the return
statement in twentyseventeen_edit_link()
function is not neccessary because the edit_post_link()
function always returns null
.
Attachments (1)
Change History (11)
#1
@
8 years ago
- Component changed from Themes to Bundled Theme
- Summary changed from Remove uneccessary return statement in twentyseventeen_edit_link() to Twenty Seventeen: Remove uneccessary return statement in twentyseventeen_edit_link()
#2
@
8 years ago
- Keywords has-patch added
- Milestone changed from Awaiting Review to 4.7.5
- Type changed from enhancement to defect (bug)
- Version changed from trunk to 4.7
#3
follow-up:
↓ 4
@
8 years ago
what about the line
twentyseventeen_edit_link( get_the_ID() );
in:
content-front-page-panels.php content-front-page.php content-page.php
?
#5
@
8 years ago
40516.diff Applies cleanly.
This ticket was mentioned in Slack in #core by desrosj. View the logs.
8 years ago
#7
@
8 years ago
- Milestone changed from 4.7.5 to 4.8
Looks like this just needs an owner. Putting it in 4.8
.
This ticket was mentioned in Slack in #core by obenland. View the logs.
8 years ago
Note: See
TracTickets for help on using
tickets.
Yep, actually
edit_post_link()
echoes the link and doesn't return anything so the implementation here doesn't look correct to me. Thanks @truongwp !