Opened 8 years ago
Closed 8 years ago
#40529 closed defect (bug) (fixed)
Improve the Dashboard News widget no-js notice
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Widgets | Keywords: | has-screenshots has-patch |
Focuses: | ui | Cc: |
Attachments (2)
Change History (7)
#1
@
8 years ago
- Keywords has-patch added
- Milestone changed from Awaiting Review to 4.8
- Owner set to afercia
- Status changed from new to assigned
Note: See
TracTickets for help on using
tickets.
Screenshot with the patch applied:
Couple notes:
I'd propose to remove the
overflow: hidden
property set on the form for the configurable widgets, because the focus style around focusable elements gets cut-off:The patch uses the CSS class
wp-clearfix
instead ofoverflow: hidden
The patch removes the selector
#dashboard_primary .dashboard-widget-control-form
because it targets the configurable widgets form: the News widget (#dashboard_primary
) is not configurable any longer since the Dashboard redesign, so this selector seems a leftover. See [26144] and [26230]It was used in WordPress 3.7 and before, for the Primary feed (Dev Blog) Widget. At that time, the News widget was the Secondary Feed (Planet) Widget. Screenshot from WordPress 3.7:
To test:
vagrant ssh
and then usingwp transient delete --all