Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#40534 closed task (blessed) (fixed)

Avoid skipping canonical tests for tickets that are open

Reported by: johnbillion's profile johnbillion Owned by: johnbillion's profile johnbillion
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: needs-patch
Focuses: Cc:


Canonical URL tests are the only ones that still get skipped if they specify a ticket number and the ticket on Trac is still open.

Everything about this is wrong.

  1. You can make your test suite go from a failing state to a passing state by re-opening a ticket on Trac. This actually happened here but nobody noticed because the test suite is covered in skipped tests anyway.
  2. You can grab a patch from an open canonical ticket and run the test suite and all of its new tests will be skipped and you won't even know it.
  3. This is all a remnant of the test suite behaviour before #30284.

Change History (1)

#1 @johnbillion
7 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 40518:

Build/Test Tools: Avoid skipping canonical tests that are connected to open Trac tickets.

This is a remnant of the test suite behaviour before #30284 fixed most of it and makes it far too easy to hide failing tests.

If any tests begin to fail as a result of this change then they should be fixed.

Fixes #40534

Note: See TracTickets for help on using tickets.