Opened 8 years ago
Closed 5 years ago
#40535 closed defect (bug) (worksforme)
Tests_DB::test_locale_floats() cannot be tested on Travis
Reported by: | johnbillion | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Database | Keywords: | |
Focuses: | Cc: |
Description
The Tests_DB::test_locale_floats()
test relies on one of the following locales to be available:
- ru_RU.utf8
- fr_FR.utf8
- de_DE.utf8
- es_ES.utf8
However none of these locales are installed on the environment used by Travis, so the test is skipped. The following locales are available, but they're all English:
- en_AG.utf8
- en_AU.utf8
- en_BW.utf8
- en_CA.utf8
- en_DK.utf8
- en_GB.utf8
- en_HK.utf8
- en_IE.utf8
- en_IN.utf8
- en_NG.utf8
- en_NZ.utf8
- en_PH.utf8
- en_SG.utf8
- en_US.utf8
- en_ZA.utf8
- en_ZM.utf8
- en_ZW.utf8
The test was introduced in #19861.
Change History (7)
#3
in reply to:
↑ 1
;
follow-up:
↓ 4
@
8 years ago
Replying to johnbillion:
@SergeyBiryukov Any ideas?
Seems like installing custom language packs on before_install should work?
#4
in reply to:
↑ 3
@
8 years ago
Replying to SergeyBiryukov:
Replying to johnbillion:
@SergeyBiryukov Any ideas?
Seems like installing custom language packs on before_install should work?
Lets see, in a quick hacky patch I added de, es, fr, and ru language pack per Travis CI docs:
https://github.com/aaronjorbin/develop.wordpress/pull/47
Notes: The packages should remain cached as apt
packages are already included in the cache config, though it will still install them for the JS only test needlessly slowing this build job down
#5
@
8 years ago
Only one of the jobs is not erroring, the HHVM job as the apt
command isn't available in all Travis CI environemnts
https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/224804646
From my quick look at the job the test_locale_floats()
test hasn't failed or been skipped
A patch can be created by following Travis CI's docs on adding apt packages:
https://docs.travis-ci.com/user/migrating-from-legacy/#How-do-I-install-APT-sources-and-packages%3F
#7
@
5 years ago
- Keywords needs-unit-tests removed
- Milestone Awaiting Review deleted
- Resolution set to worksforme
- Status changed from new to closed
It looks like Travis includes some popular locales now, here's the output from one of the recent builds:
$ locale -a ar_AE.utf8 ar_EG.utf8 C C.UTF-8 de_AT.utf8 de_BE.utf8 de_CH.utf8 de_DE.utf8 en_AG en_AG.utf8 en_AU.utf8 en_BW.utf8 en_CA.utf8 en_DK.utf8 en_GB.utf8 en_HK.utf8 en_IE.utf8 en_IN en_IN.utf8 en_NG en_NG.utf8 en_NZ.utf8 en_PH.utf8 en_SG.utf8 en_US.utf8 en_ZA.utf8 en_ZM en_ZM.utf8 en_ZW.utf8 es_ES.utf8 es_MX.utf8 fr_BE.utf8 fr_CH.utf8 fr_FR.utf8 he_IL.utf8 hi_IN hi_IN.utf8 ja_JP.utf8 ko_KR.utf8 ms_MY.utf8 POSIX pt_BR.utf8 pt_PT.utf8 ru_RU.utf8 ru_UA.utf8 uk_UA.utf8 zh_CN.utf8 zh_TW.utf8
Tests_DB::test_locale_floats()
is no longer skipped and runs as expected. Marking the ticket as resolved.
@SergeyBiryukov Any ideas?