WordPress.org

Make WordPress Core

Opened 13 months ago

Last modified 13 months ago

#40535 new defect (bug)

Tests_DB::test_locale_floats() cannot be tested on Travis

Reported by: johnbillion Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Database Keywords: needs-unit-tests
Focuses: Cc:

Description

The Tests_DB::test_locale_floats() test relies on one of the following locales to be available:

  • ru_RU.utf8
  • fr_FR.utf8
  • de_DE.utf8
  • es_ES.utf8

However none of these locales are installed on the environment used by Travis, so the test is skipped. The following locales are available, but they're all English:

  • en_AG.utf8
  • en_AU.utf8
  • en_BW.utf8
  • en_CA.utf8
  • en_DK.utf8
  • en_GB.utf8
  • en_HK.utf8
  • en_IE.utf8
  • en_IN.utf8
  • en_NG.utf8
  • en_NZ.utf8
  • en_PH.utf8
  • en_SG.utf8
  • en_US.utf8
  • en_ZA.utf8
  • en_ZM.utf8
  • en_ZW.utf8

The test was introduced in #19861.

Change History (6)

#1 follow-up: @johnbillion
13 months ago

@SergeyBiryukov Any ideas?

#2 @johnbillion
13 months ago

In 40529:

Build/Test Tools: Partially revert [40524].

See #40533, #40535

#3 in reply to: ↑ 1 ; follow-up: @SergeyBiryukov
13 months ago

Replying to johnbillion:

@SergeyBiryukov Any ideas?

Seems like installing custom language packs on before_install should work?

#4 in reply to: ↑ 3 @netweb
13 months ago

Replying to SergeyBiryukov:

Replying to johnbillion:

@SergeyBiryukov Any ideas?

Seems like installing custom language packs on before_install should work?

Lets see, in a quick hacky patch I added de, es, fr, and ru language pack per Travis CI docs:

https://github.com/aaronjorbin/develop.wordpress/pull/47

Notes: The packages should remain cached as apt packages are already included in the cache config, though it will still install them for the JS only test needlessly slowing this build job down

#5 @netweb
13 months ago

Only one of the jobs is not erroring, the HHVM job as the apt command isn't available in all Travis CI environemnts

https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/224804646

From my quick look at the job the test_locale_floats() test hasn't failed or been skipped

A patch can be created by following Travis CI's docs on adding apt packages:

https://docs.travis-ci.com/user/migrating-from-legacy/#How-do-I-install-APT-sources-and-packages%3F

#6 @johnbillion
13 months ago

  • Component changed from Build/Test Tools to Database
Note: See TracTickets for help on using tickets.