WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 4 weeks ago

Last modified 4 weeks ago

#40548 closed task (blessed) (fixed)

Remove HHVM from the test matrix on Travis

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Focuses: Cc:

Description

Maintaining the HHVM test infrastructure on Travis takes a disproportionately high amount of effort. Particularly because the HHVM build:

  • Is in the allowed failures list
  • Has never passed
  • Often errors

Given the exceptionally low usage numbers of HHVM, support in the Travis test suite should be removed.

The PHP world owes a lot to HHVM for helping it push it forward. Without HHVM, maybe we wouldn't have seen such incredible performance gains in PHP 7. Thank you, HHVM.

Attachments (1)

40548.diff (7.8 KB) - added by netweb 2 months ago.

Download all attachments as: .zip

Change History (21)

#1 @johnbillion
2 months ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 40546:

Build/Test Tools: Remove HHVM from the test infrastructure on Travis.

Fixes #40548

#2 @johnbillion
2 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#3 @johnbillion
2 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 40547:

Build/Test Tools: Backport various recent changes to the 4.7 branch.

  • Add support for PHPUnit 6+.
  • Add Composer files to the cache on Travis.
  • Remove HHVM from the test infrastructure on Travis.

Merges [40536], [40538], [40539], and [40546] to the 4.7 branch.

See #40539
Fixes #39822, #40548

#4 @netweb
2 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening, branches back to 4.0 still contain remnants of HHVM in .travis.yml, we should remove all these.

@netweb
2 months ago

#5 @netweb
2 months ago

  • Keywords has-patch commit added

Patch 40548.diff removes .travis.yml HHVM references in the 4.0-4.6 branches via [40536] / [40546] changesets

This ticket was mentioned in Slack in #hosting-community by netweb. View the logs.


2 months ago

This ticket was mentioned in Slack in #core by obenland. View the logs.


5 weeks ago

#8 @obenland
5 weeks ago

@johnbillion Could you take another look here?

#9 @johnbillion
5 weeks ago

In 40818:

Build/Test Tools: Remove mentions of HHVM from the test infrastructure on Travis for the 4.6 branch.

Props netweb

See #40548

This ticket was mentioned in Slack in #core by obenland. View the logs.


4 weeks ago

#11 @obenland
4 weeks ago

@johnbillion Can this be closed?

#12 @johnbillion
4 weeks ago

  • Status changed from reopened to accepted

A few more branch to commits to go then we'll be done.

#13 @johnbillion
4 weeks ago

In 40828:

Build/Test Tools: Remove mentions of HHVM from the test infrastructure on Travis for the 4.5 branch.

Props netweb

See #40548

#14 @johnbillion
4 weeks ago

In 40829:

Build/Test Tools: Remove mentions of HHVM from the test infrastructure on Travis for the 4.4 branch.

See #40548

#15 @johnbillion
4 weeks ago

In 40830:

Build/Test Tools: Remove mentions of HHVM from the test infrastructure on Travis for the 4.3 branch.

See #40548

#16 @johnbillion
4 weeks ago

In 40831:

Build/Test Tools: Remove mentions of HHVM from the test infrastructure on Travis for the 4.2 branch.

See #40548

#17 @johnbillion
4 weeks ago

In 40832:

Build/Test Tools: Remove mentions of HHVM from the test infrastructure on Travis for the 4.1 branch.

See #40548

#18 @johnbillion
4 weeks ago

In 40833:

Build/Test Tools: Remove mentions of HHVM from the test infrastructure on Travis for the 4.0 branch.

See #40548

#19 @johnbillion
4 weeks ago

  • Keywords fixed-major removed
  • Resolution set to fixed
  • Status changed from accepted to closed

This ticket was mentioned in Slack in #core by desrosj. View the logs.


4 weeks ago

Note: See TracTickets for help on using tickets.