Changes between Version 4 and Version 5 of Ticket #40568, comment 21
- Timestamp:
- 11/11/2020 07:47:59 PM (4 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #40568, comment 21
v4 v5 16 16 If we think there will ever be a future need to have this always fire, now is the time to get that right. 17 17 18 I also feel like `wp_error_checked` is not an obvious hook name for what this function is historically used for. I use it all over the place to make sure something is not a `WP_Error` and to take appropriate action if so. I have never used this function with the intent of denoting a single instance of having checked for an error. That means I may check the same object multiple times looking for multiple failures, because a single `WP_Error` object may contain multiple errors. See: [https://bbpress.trac.wordpress.org/browser/trunk/src/includes/core/functions.php#L276 bbPress].18 I also feel like `wp_error_checked` is not an obvious hook name for what this function is historically used for. I use it all over the place to make sure something is or is not a `WP_Error` and to take appropriate action either way. I have never used this function with the intent of denoting a single instance of having checked for an error. That means I may check the same object multiple times looking for multiple failures, because a single `WP_Error` object may contain multiple errors. See: [https://bbpress.trac.wordpress.org/browser/trunk/src/includes/core/functions.php#L276 bbPress].