Opened 18 years ago
Closed 18 years ago
#4057 closed enhancement (fixed)
Add widgets compatibility to default and classic themes
Reported by: | Otto42 | Owned by: | rob1n |
---|---|---|---|
Milestone: | 2.2 | Priority: | normal |
Severity: | normal | Version: | 2.1.2 |
Component: | Template | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Widget compatibility really should be in the core code. Just my opinion, but it would save a lot of people a lot of trouble.
Even if we don't move the widgets plugin in as a default included plugin, it would be nice if the core themes were widget-friendly, in the hopes that people making themes will get the hint and make their themes widget friendly as well.
Patch included. It's not exactly the same as the mods that come with the widgets plugin, as I felt it was useful to explicitly specify the before & after bits for each theme in the functions.php files instead of hoping that the defaults for the widgets plugin don't change.
Attachments (2)
Change History (12)
#2
@
18 years ago
- Keywords 2nd-opinion added
I recall discussing this with Ryan a few weeks ago and the response was that it wasn't necessary. I'm not sure if that's changed, though it might make a nice addition.
+1.
#3
@
18 years ago
- Keywords commit added; 2nd-opinion removed
Just talked to Matt, and it's going in. Sweet.
#5
@
18 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
You forgot to add the new functions.php file for the classic theme, unless it's in another changeset or I'm stupid and missing something. ;-)
#6
@
18 years ago
- Owner changed from anonymous to rob1n
- Status changed from reopened to new
Nah, I'm just an idiot :\.
#8
@
18 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Just by looking at it, I think there's a typo in /wp-content/themes/classic/functions.php
at r5154 on line 2. It should be
if ( function_exists('register_sidebar') )
and not the plural register_sidebars
. Patch attached.
Adds widget support to the default and classic themes.