WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#4058 closed enhancement (fixed)

"View" class for links in post/page listings

Reported by: rgovostes Owned by: rob1n
Milestone: 2.3 Priority: low
Severity: trivial Version: 2.1.2
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

I am writing a plugin that needs to be able to alter the "View" links in the Manage Pages listing. I thought it would be easy to just rewrite all the <a> tags on the page with the "view" class -- but all the "View" links have a class of "edit"!

The patch adds a new "view" class and corrects the links in both the post and page listings. I also changed some quotation marks for consistency.

Attachments (3)

viewclass.patch (2.1 KB) - added by rgovostes 7 years ago.
Adds a:view class to CSS files and corrects links to use it
4058.diff (997 bytes) - added by rob1n 7 years ago.
4058.complete.diff (2.3 KB) - added by westi 7 years ago.
The complete patch - make sure we fix for pages as well as posts

Download all attachments as: .zip

Change History (8)

rgovostes7 years ago

Adds a:view class to CSS files and corrects links to use it

comment:1 Nazgul7 years ago

  • Keywords has-patch added
  • Milestone set to 2.3

comment:2 rob1n7 years ago

  • Owner changed from anonymous to rob1n
  • Status changed from new to assigned

+1 for the concept, -1 for the patch. Why replace " with '?

rob1n7 years ago

comment:3 rob1n7 years ago

  • Keywords commit added; css manage pages posts list listing removed

comment:4 markjaquith7 years ago

rgovostes,

We're not really worried about HTML quotes consistency, application-wide. Both are valid. Really, we just use whichever is more convenient with the type of PHP quoting we're using, to avoid backslash escaping.

westi7 years ago

The complete patch - make sure we fix for pages as well as posts

comment:5 westi7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [5927]) Give the view links in post/page listings the view class rather than the edit class, fixes #4058 props rgovostes

Note: See TracTickets for help on using tickets.