Make WordPress Core

Opened 6 years ago

Closed 15 months ago

Last modified 14 months ago

#40582 closed enhancement (fixed)

Capitalize character - "CTRL + a" -> "CTRL + A"

Reported by: presskopp's profile Presskopp Owned by: audrasjb's profile audrasjb
Milestone: 6.0 Priority: normal
Severity: minor Version: 4.7.4
Component: Administration Keywords: has-patch needs-user-docs
Focuses: ui-copy Cc:


Attachments (5)

40582.diff (4.3 KB) - added by Presskopp 6 years ago.
40582.2.diff (4.3 KB) - added by Presskopp 6 years ago.
ctrl.jpg (50.7 KB) - added by Presskopp 6 years ago.
40582.tinymce.diff (851 bytes) - added by sabernhardt 2 years ago.
40582.permalink.diff (3.2 KB) - added by sabernhardt 2 years ago.

Download all attachments as: .zip

Change History (24)

6 years ago

#1 @Presskopp
6 years ago

  • Severity changed from normal to minor

Second patch is variant with Ctrl + A

(We have "CTRL + V" in wp-includes\js\tinymce\langs\wp-langs-en.js)

Last edited 6 years ago by Presskopp (previous) (diff)

6 years ago

6 years ago


#2 @garrett-eclipse
3 years ago

  • Component changed from Text Changes to TinyMCE
  • Focuses ui-copy added

#3 @sabernhardt
2 years ago

To match wp-includes/class-wp-editor.php, 40582.tinymce.diff has lowercase letters after the capital C: Ctrl + V. Likewise, 40582.permalink.diff has Ctrl + A, and it includes some small grammatical changes.

These patches are purposely separate because ticket:40763#comment:6 recommended the removal of Ctrl + A and "we" wording (see also #46057). So I'll open a new ticket to explore more substantial Permalinks text changes (#53141) and to add label tags for each textarea (#53142).

Last edited 2 years ago by sabernhardt (previous) (diff)

#4 follow-up: @joyously
22 months ago

I don't think this change should be made.
It is confusing to see a capital letter because you need to use the shift key to get the capital. I have wondered about that in the past (not necessarily with this particular software).

And on my keyboard, it says "ctrl", not "Ctrl" or "CTRL".

#5 @sabernhardt
22 months ago

  • Keywords 2nd-opinion added

#6 @sabernhardt
22 months ago

The proposed capitalization change is for consistency, but I don't have a strong opinion about it.

#7 @Presskopp
22 months ago

I'm also not sure if the proposal is about capitalization or decapitalization. But yes, it's about consistency.

#8 in reply to: ↑ 4 @SergeyBiryukov
22 months ago

  • Keywords commit added

Replying to joyously:

It is confusing to see a capital letter because you need to use the shift key to get the capital.

That's a valid point. However, it looks like the patches here just make sure we use a consistent format for keyboard shortcuts in core, which I think is preferable to using an inconsistent format :) Whether the format itself should be changed, can be discussed in a new ticket.

It's also worth noting that keys on the keyboard itself generally use capital letters.

And on my keyboard, it says "ctrl", not "Ctrl" or "CTRL".

On mine it's "Ctrl" :)

Last edited 22 months ago by SergeyBiryukov (previous) (diff)

#9 @audrasjb
17 months ago

  • Keywords commit removed
  • Milestone changed from Awaiting Review to 6.0
  • Owner set to audrasjb
  • Status changed from new to reviewing

#10 @audrasjb
15 months ago

  • Component changed from TinyMCE to Administration
  • Keywords has-patch needs-refresh added

Moving to component "Administration" as the change is not only related to TinyMCE :)

This ticket was mentioned in PR #2364 on WordPress/wordpress-develop by audrasjb.

15 months ago

  • Keywords needs-refresh removed

#12 @audrasjb
15 months ago

Marking for commit.

#13 @audrasjb
15 months ago

  • Keywords commit added; 2nd-opinion removed

#14 @audrasjb
15 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 52808:

Administration: Consistency fixes on keyboard shortcuts instructions.

This changeset capitalizes the letter of keyboard shortcuts and replaces CTRL with Ctrl, for better consistency.

Props Presskopp, sabernhardt, joyously, SergeyBiryukov, audrasjb.
Fixes #40582.

#16 @audrasjb
15 months ago

  • Keywords commit removed

@sabernhardt regarding the use of "if it was"/"if it were", I started to open a new ticket to address this issue, but as I'm not a native English speaker I checked on the internet and I'm not 100% sure we need to change anything…

#17 @sabernhardt
15 months ago

At this point, any changes to the Permalinks error messages can be addressed on #53141. And the suggested text there restructures the sentences, so the subjunctive "were" would not fit anyway.

#18 @milana_cap
15 months ago

  • Keywords needs-codex added

#19 @dd32
14 months ago

  • Keywords needs-user-docs added; needs-codex removed
Note: See TracTickets for help on using tickets.