Capitalize character - "CTRL + a" -> "CTRL + A"

[Presskopp]

Second patch is variant with Ctrl + A

(We have "CTRL + V" in wp-includes\js\tinymce\langs\wp-langs-en.js)

[Presskopp]

well..

[sabernhardt]

To match wp-includes/class-wp-editor.php, 40582.tinymce.diff​ has lowercase letters after the capital C: Ctrl + V. Likewise, 40582.permalink.diff​ has Ctrl + A, and it includes some small grammatical changes.

These patches are purposely separate because ticket:40763#comment:6 recommended the removal of Ctrl + A and "we" wording (see also #46057). So I'll open a new ticket to explore more substantial Permalinks text changes (#53141) and to add label tags for each textarea (#53142).

[joyously]

I don't think this change should be made.
It is confusing to see a capital letter because you need to use the shift key to get the capital. I have wondered about that in the past (not necessarily with this particular software).

And on my keyboard, it says "ctrl", not "Ctrl" or "CTRL".

[sabernhardt]

The proposed capitalization change is for consistency, but I don't have a strong opinion about it.

[Presskopp]

I'm also not sure if the proposal is about capitalization or decapitalization. But yes, it's about consistency.

[SergeyBiryukov]

Replying to joyously:

It is confusing to see a capital letter because you need to use the shift key to get the capital.

That's a valid point. However, it looks like the patches here just make sure we use a consistent format for keyboard shortcuts in core, which I think is preferable to using an inconsistent format :) Whether the format itself should be changed, can be discussed in a new ticket.

And on my keyboard, it says "ctrl", not "Ctrl" or "CTRL".

On mine it's "Ctrl" :)

[audrasjb]

Moving to component "Administration" as the change is not only related to TinyMCE :)

Trac ticket: https://core.trac.wordpress.org/ticket/40582

[audrasjb]

Marking for commit.

[audrasjb]

In 52808:

Administration: Consistency fixes on keyboard shortcuts instructions.

This changeset capitalizes the letter of keyboard shortcuts and replaces CTRL with Ctrl, for better consistency.

Props Presskopp, sabernhardt, joyously, SergeyBiryukov, audrasjb.
Fixes #40582.

Committed in https://core.trac.wordpress.org/changeset/52808

[audrasjb]

@sabernhardt regarding the use of "if it was"/"if it were", I started to open a new ticket to address this issue, but as I'm not a native English speaker I checked on the internet and I'm not 100% sure we need to change anything…

​https://www.quora.com/When-do-you-use-if-it-were-and-if-it-was

[sabernhardt]

At this point, any changes to the Permalinks error messages can be addressed on #53141. And the suggested text there restructures the sentences, so the subjunctive "were" would not fit anyway.