WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 3 months ago

#40582 new enhancement

Capitalize character - "CTRL + a" -> "CTRL + A"

Reported by: Presskopp Owned by:
Milestone: Awaiting Review Priority: normal
Severity: minor Version: 4.7.4
Component: TinyMCE Keywords: 2nd-opinion commit
Focuses: ui-copy Cc:

Description


Attachments (5)

40582.diff (4.3 KB) - added by Presskopp 5 years ago.
40582.2.diff (4.3 KB) - added by Presskopp 5 years ago.
ctrl.jpg (50.7 KB) - added by Presskopp 5 years ago.
well..
40582.tinymce.diff (851 bytes) - added by sabernhardt 8 months ago.
40582.permalink.diff (3.2 KB) - added by sabernhardt 8 months ago.

Download all attachments as: .zip

Change History (13)

@Presskopp
5 years ago

#1 @Presskopp
5 years ago

  • Severity changed from normal to minor

Second patch is variant with Ctrl + A

(We have "CTRL + V" in wp-includes\js\tinymce\langs\wp-langs-en.js)

Last edited 5 years ago by Presskopp (previous) (diff)

@Presskopp
5 years ago

@Presskopp
5 years ago

well..

#2 @garrett-eclipse
22 months ago

  • Component changed from Text Changes to TinyMCE
  • Focuses ui-copy added

#3 @sabernhardt
8 months ago

To match wp-includes/class-wp-editor.php, 40582.tinymce.diff has lowercase letters after the capital C: Ctrl + V. Likewise, 40582.permalink.diff has Ctrl + A, and it includes some small grammatical changes.

These patches are purposely separate because ticket:40763#comment:6 recommended the removal of Ctrl + A and "we" wording (see also #46057). So I'll open a new ticket to explore more substantial Permalinks text changes (#53141) and to add label tags for each textarea (#53142).

Last edited 6 months ago by sabernhardt (previous) (diff)

#4 follow-up: @joyously
3 months ago

I don't think this change should be made.
It is confusing to see a capital letter because you need to use the shift key to get the capital. I have wondered about that in the past (not necessarily with this particular software).

And on my keyboard, it says "ctrl", not "Ctrl" or "CTRL".

#5 @sabernhardt
3 months ago

  • Keywords 2nd-opinion added

#6 @sabernhardt
3 months ago

The proposed capitalization change is for consistency, but I don't have a strong opinion about it.

#7 @Presskopp
3 months ago

I'm also not sure if the proposal is about capitalization or decapitalization. But yes, it's about consistency.

#8 in reply to: ↑ 4 @SergeyBiryukov
3 months ago

  • Keywords commit added

Replying to joyously:

It is confusing to see a capital letter because you need to use the shift key to get the capital.

That's a valid point. However, it looks like the patches here just make sure we use a consistent format for keyboard shortcuts in core, which I think is preferable to using an inconsistent format :) Whether the format itself should be changed, can be discussed in a new ticket.

It's also worth noting that keys on the keyboard itself generally use capital letters.

And on my keyboard, it says "ctrl", not "Ctrl" or "CTRL".

On mine it's "Ctrl" :)

Last edited 3 months ago by SergeyBiryukov (previous) (diff)
Note: See TracTickets for help on using tickets.