Make WordPress Core

Opened 9 years ago

Closed 12 months ago

#40585 closed defect (bug) (worksforme)

'Update' vs 'Schedule'

Reported by: micheleconversano Owned by:
Priority: normal Milestone:
Component: Posts, Post Types Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Hi, today i work with WordPress and i noticed a problem. My timeline event is:
1) I have an article "X" published of the 26 april at 20.00.
2) Today, 27 april at 18.02 i start the edit the article
3) At 18.15 finish edit article and modified date of article in pubblication in 27 april at 18.15
4) Now i don't look button "Update" but i look button "Planning".

I have feeling that WordPress don't check date in this moment (18.15) but check date open edit article (18.02).

The article is pubblished in all cases but theoretically the article is deleter on the google serp for some minutes.

Sorry for my english :)

Attachments (1)

40585.diff (829 bytes ) - added by swissspidy 9 years ago.

Download all attachments as: .zip

Change History (9)

#1 @Ipstenu
9 years ago

  • Resolutioninvalid
  • Status newclosed

I'm sorry but this is not a bug report for issues with WordPress core

You can post asking for help debugging the situation in https://wordpress.org/support/

If you don't change the time/date stamp for WordPress, then when you publish a post it will be 'now' even if you save it as pending.

If you DO edit the time or day, WordPress keeps that no matter what future changes you make.

#2 @swissspidy
9 years ago

  • Milestone Awaiting Review

#3 @SergeyBiryukov
9 years ago

  • Component GeneralPosts, Post Types

#4 @SergeyBiryukov
9 years ago

  • Summary update vs planning'Update' vs 'Schedule'

@swissspidy
9 years ago

#5 @swissspidy
9 years ago

#40693 was marked as a duplicate.

#6 @swissspidy
9 years ago

  • Keywords has-patch added
  • MilestoneAwaiting Review
  • Resolution invalid
  • Status closedreopened

Reopening as per #40693.

#7 @swissspidy
9 years ago

  • Keywords needs-testing added

The patch is by micheleconversano, just so we don't forget to give props if legit.

#8 @SirLouen
12 months ago

  • Keywords needs-testing removed
  • Milestone Awaiting Review
  • Resolutionworksforme
  • Status reopenedclosed

Reproduction Report

Description

❌ This report can't validates that the issue can be reproduced.

Environment

  • WordPress: 6.9-alpha-60093-src
  • PHP: 8.2.29
  • Server: nginx/1.29.1
  • Database: mysqli (Server: 8.4.6 / Client: mysqlnd 8.2.29)
  • Browser: Chrome 139.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Twenty 2.9
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0
    • User Switching 1.10.0

Testing Instructions

  • Trying to reproduce the steps in OP
  1. Create a post in the past, say yesterday. Publish it.
  2. Edit the post in the past.
  3. Wait one or two minutes
  4. Check for title of the save button
  5. 👌 The button is "Update"

Actual Results

  1. ❌ Issue is not happening

Additional Notes

  • I can't really reproduce the instructions. Checking at the provided patch, I'm not even sure what to expect

current_time without parameters gets:

$datetime = new DateTime( 'now', wp_timezone() );
  • Revisions are set at the right time
  • The comparison is being done between time which returns the GMT current time, and the post_date_gmt which is the exact time in GMT. So both should patch. current_time would only make sense if we compared with post_date
  • In conclusion, I'm not sure if the reporter was doing something wrong, but considering that is not reproducible, and nothing has moved for 8 years, its time to close this as worksforme
Note: See TracTickets for help on using tickets.