Make WordPress Core

Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#4059 closed defect (bug) (wontfix)

L10N Support in Default Theme

Reported by: sewar's profile Sewar Owned by: sewar's profile Sewar
Milestone: Priority: low
Severity: normal Version: 2.1.2
Component: I18N Keywords: has-patch 2nd-opinion i18n
Focuses: Cc:


See #3953 for details

Attachments (2)

Kubrick-L10N.diff (42.3 KB) - added by Sewar 17 years ago.
Kubrick-l10n-part2.diff (14.2 KB) - added by abelcheung 17 years ago.
Additional patch on top of Sewar's

Download all attachments as: .zip

Change History (16)

#1 @rob1n
17 years ago

  • Keywords 2nd-opinion added

I think it's a good idea. Makes sense that seeing it done in the default theme would encourage people to do it in their own themes.

#2 @nbachiyski
17 years ago

  • Keywords i18n added
  • The beginning of comments-popup has a naked printf, without __
  • There are some places (for example "« %link" and "%s at %s", %1$s to “%2$s”"), where we could use the new _c function (see #3687)
  • Some more changes, differenet from i18n have passed through your diff: some stylesheet modifications (Arabic fonts), for example.
  • It is nice that the strings are in a different domain--the theme authors will be more and more inspired and will gain some know-how :-)

Very good work, Sewar! Let's hope Matt wouldn't mind letting this in.

17 years ago

#3 @Sewar
17 years ago

  • Cc Sewar added

I have updated the patch, fixed the bug in comments-popup.php file, removed CSS related fixes (the Arabic fonts) and will add them in new ticket.

About the new _c function, it looks its development didn't finished yet.

#4 @abelcheung
17 years ago

The _c() function has already landed in subversion. Just that nbachiyski propose to put the context part behind the real translatable string, instead of the current status (before the real string).

#5 @abelcheung
17 years ago

  • Cc abelcheung added

#6 @abelcheung
17 years ago

Couple of places that looks curious to me:

  1. Why some of the ‘ and ’ are replaced by ' ?
  2. In sidebar.php, why inserting link breaks in between middle of certain sentences but not others?

17 years ago

Additional patch on top of Sewar's

#7 @abelcheung
17 years ago

I have uploaded additional stuff on top of Sewar's patch:

  • Header image and color page now localizable
  • Mark more strings translatable and minor fixes here and there

#8 @rob1n
17 years ago

  • Milestone changed from 2.2 to 2.3

#9 @rob1n
17 years ago

  • Component changed from Template to i18n

#10 @abelcheung
17 years ago

  • Cc abelcheung removed

#12 @foolswisdom
17 years ago

  • Cc nbachiyski@… added

#13 @nbachiyski
17 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

#14 @Nazgul
17 years ago

  • Milestone 2.3 deleted
Note: See TracTickets for help on using tickets.