WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 months ago

#40594 closed enhancement (fixed)

Reset box shadow for links in the admin bar

Reported by: FlorianBrinkmann Owned by: sabernhardt
Milestone: 5.8 Priority: normal
Severity: normal Version: 4.8
Component: Toolbar Keywords: has-patch needs-testing
Focuses: css Cc:

Description

I am currently working on a theme which uses box-shadow for link underline. Because the box-shadow property does not get a reset in the admin bar CSS, each link in the admin bar gets a box shadow too (see screenshot).

Attachments (3)

admin-bar-box-shadow.png (30.8 KB) - added by FlorianBrinkmann 4 years ago.
40594.patch (415 bytes) - added by FlorianBrinkmann 4 years ago.
Adds reset for box-shadow in admin-bar.css
40594.1.patch (348 bytes) - added by sabernhardt 5 months ago.
refresh

Download all attachments as: .zip

Change History (7)

@FlorianBrinkmann
4 years ago

Adds reset for box-shadow in admin-bar.css

#1 @FlorianBrinkmann
4 years ago

  • Keywords has-patch added

#2 @danieltj
4 years ago

  • Keywords needs-testing added

Reviving this so we can look at implementing something. A CSS reset should be simple enough to get something worked out. I'll see if I can test the patch that @FlorianBrinkmann has provided on 4.9.

@sabernhardt
5 months ago

refresh

#3 @sabernhardt
5 months ago

  • Focuses css added
  • Milestone changed from Awaiting Review to 5.8
  • Owner set to sabernhardt
  • Status changed from new to accepted

Patch refreshed

#4 @ryelle
3 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 50847:

Toolbar: Reset box-shadow on links.

This prevents any theme-added box-shadow styles from applying to the toolbar items.

Props sabernhardt, florianbrinkmann.
Fixes #40594.

Note: See TracTickets for help on using tickets.