WordPress.org

Make WordPress Core

Opened 13 years ago

Closed 10 years ago

Last modified 10 years ago

#4060 closed enhancement (duplicate)

Custom Header Support in Default Theme

Reported by: Sewar Owned by:
Milestone: Priority: low
Severity: normal Version: 2.1.2
Component: Themes Keywords: needs-patch
Focuses: Cc:
PR Number:

Description

Default theme contain custom header in it, version 2.1 implemented it in WP core, but default theme still use its custom code, it should use Custom_Header class.

Attachments (2)

4060.diff (16.9 KB) - added by Sewar 13 years ago.
default.zip (59.0 KB) - added by ryan 13 years ago.

Download all attachments as: .zip

Change History (21)

#1 @rob1n
13 years ago

Hate to sound stupid, but I can't find a Custom_Header class in the core...

#2 @rob1n
13 years ago

Or are you suggesting we create a new class to deal with custom headers?

#3 @rob1n
13 years ago

  • Cc rob1n added

#4 @rob1n
13 years ago

  • Keywords needs-patch removed

#5 @Otto42
13 years ago

I think he's talking about the add_custom_image_header() function in wp_includes/theme.php and the Custom_image_header class wp_admin/custom-header.php.

#6 @rob1n
13 years ago

Ahhh. That would make more sense.

#7 @Sewar
13 years ago

  • Keywords needs-patch added

As Otto42 said, i mean Custom_image_header class in custom-header.php. As i said in description, custom header support implemented in WP 2.1, see [4673] and #3465.

Currently some (or most) of WP.com themes supports this feature, you can use them as a reference for create a patch.

#8 @rob1n
13 years ago

  • Milestone changed from 2.2 to 2.3
  • Owner changed from anonymous to rob1n

@Sewar
13 years ago

#9 @Sewar
13 years ago

  • Keywords has-patch needs-testing added; needs-patch removed
  • Milestone changed from 2.3 to 2.2

The patch needs testing by another developer. It looks bad, but works.

#10 @foolswisdom
13 years ago

  • Milestone changed from 2.2 to 2.3

Thanks for the patch!

Can wait till 2.3 , no reason to rush it in at the end.

#11 @rob1n
13 years ago

  • Cc rob1n removed

#12 @ryan
13 years ago

The default theme does support custom coloring in the header though. It allows color fades. On worpress.com, Kubrick has both custom header image and custom header coloring, but they don't cooperate very well and the corner curves show beneath the custom image. I'll attach the default theme with the wpcom changes if someone wants to try making both custom coloring and custom images play nice together.

@ryan
13 years ago

#13 @ryan
12 years ago

  • Milestone changed from 2.3 to 2.4 (next)

#14 @rob1n
12 years ago

  • Owner rob1n deleted

#15 @ryan
12 years ago

  • Milestone changed from 2.5 to 2.6

#16 @spikeyslam
12 years ago

Are color fades necessary? Don't most users who use Custom Image Header, upload their own images? It should be one or the other and not both at the same time. Custom Image Header should trump color fade if used.

#17 @Denis-de-Bernardy
11 years ago

  • Component changed from Template to Themes
  • Keywords needs-patch added; has-patch needs-testing removed
  • Milestone changed from 2.9 to Future Release
  • Type changed from defect (bug) to enhancement

#18 @markmcwilliams
10 years ago

  • Resolution set to duplicate
  • Status changed from new to closed

With a new default theme (#9015) making it's way into 3.0, and the introduction of #12343 and register_default_headers(), with the possibility to soon (If not already in?) use a solid colour header, I think we can close this as a duplicate ticket! :)

#19 @nacin
10 years ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.