WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 4 weeks ago

Last modified 4 weeks ago

#40605 closed enhancement (fixed)

Remove login form on checkemail=confirm screen

Reported by: rianrietveld Owned by: pratik028
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: good-first-bug has-patch has-screenshots commit
Focuses: ui Cc:

Description

When a user wants to retrieve her password on wp-login.php?action=lostpassword the next screen is wp-login.php?checkemail=confirm.

On that screen there is the message: Check your email for the confirmation link.
And below that is the login form again. This is confusing.

I found that users don't read the "check your email" message and fill out this form, as they think they are resetting their email with this form.

I suggest removing the login form from wp-login.php?checkemail=confirm and make the message "Check your email for the confirmation link." more stand out.

Attachments (12)

ticket#40605.patch (1.5 KB) - added by pratik028 3 years ago.
Added check-email switch case
40605.patch (1.5 KB) - added by bdbch 3 years ago.
40605.diff (1.3 KB) - added by hankthetank 3 years ago.
40605.2.patch (1.5 KB) - added by yashrs 3 years ago.
Added link(to login page) and text to ensure that user isn't confused where to go next.
40605.3.patch (1.6 KB) - added by williampatton 8 weeks ago.
Capture d’écran 2020-06-14 à 23.31.05.png (36.6 KB) - added by audrasjb 7 weeks ago.
Problem with the current patch
40605.4.diff (1.4 KB) - added by bmartinent 6 weeks ago.
I just remove the wp_signon() call, how is useless here.
Capture d’écran 2020-06-20 à 00.15.50.png (20.5 KB) - added by audrasjb 6 weeks ago.
edge case that occurs after user registration
40605.5.diff (2.5 KB) - added by bmartinent 6 weeks ago.
This new patch do not interfere with the other checkemail cases. "wp-login.php?checkemail=newpass" and "wp-login.php?checkemail=registered"
before-lost-password.png (34.6 KB) - added by florianatwhodunit 6 weeks ago.
Before patch : form is displayed
screenshot-step-1.png (36.6 KB) - added by florianatwhodunit 6 weeks ago.
After patch : step 1
screen-shot-step-2.png (23.5 KB) - added by florianatwhodunit 6 weeks ago.
After patch : step 2 : works fine

Download all attachments as: .zip

Change History (40)

#1 @johnbillion
3 years ago

  • Keywords ux-feedback needs-patch good-first-bug added
  • Type changed from defect (bug) to enhancement
  • Version trunk deleted

+1 on this

@pratik028
3 years ago

Added check-email switch case

@bdbch
3 years ago

#3 @bdbch
3 years ago

Fixed the indentation on @pratik028 solution and fixed code style to the WP standard.

#4 @allisonplus
3 years ago

  • Keywords has-patch added; needs-patch removed

#5 @DrewAPicture
3 years ago

  • Owner set to pratik028
  • Status changed from new to assigned

Assigning ownership to mark the good-first-bug as "claimed".

#6 @johnbillion
3 years ago

  • Keywords needs-patch added; ux-feedback has-patch removed

40605.patch needs more work. There are calls to log the user, and logic for handling a log out action, all of which aren't needed in this block.

@hankthetank
3 years ago

#7 @hankthetank
3 years ago

This would be my first core contribution. I have removed the calls to log the user and the logic for handling a lot out action.

@yashrs
3 years ago

Added link(to login page) and text to ensure that user isn't confused where to go next.

#8 @yashrs
3 years ago

  • Keywords has-patch added; needs-patch removed

#10 @SergeyBiryukov
3 years ago

  • Keywords early added
  • Milestone changed from Awaiting Review to Future Release

This ticket was mentioned in Slack in #core by sergey. View the logs.


3 months ago

#12 @SergeyBiryukov
3 months ago

  • Milestone changed from Future Release to 5.5

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


3 months ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


8 weeks ago

#15 @davidbaumwald
8 weeks ago

  • Keywords needs-refresh added

Patch no longer applies cleaning, marking for a refresh.

#16 @williampatton
8 weeks ago

I refreshed the patch in this ticket and adjusted the link in the string to use sprintf so there is no dynamic content in the translation.

#17 @williampatton
8 weeks ago

  • Keywords needs-refresh removed

#18 @audrasjb
7 weeks ago

  • Keywords needs-testing added

#19 @johnbillion
7 weeks ago

  • Keywords needs-screenshots added; early removed

@williampatton Patch looks good. Can you upload some screenshots please?

@audrasjb
7 weeks ago

Problem with the current patch

#20 @audrasjb
7 weeks ago

  • Keywords needs-refresh added

Hi,
There is a problem with the current patch. It displays two irrelevant errors.

#21 @audrasjb
7 weeks ago

There is also a JS error in the console, because of document.querySelector('form').classList.add('shake');. There is no form to "shake".

@bmartinent
6 weeks ago

I just remove the wp_signon() call, how is useless here.

#22 @audrasjb
6 weeks ago

  • Keywords has-screenshots added; needs-screenshots removed

Thanks @bmartinent
This looks like a great workaround 👍
Just noting some edge cases, for example within user registration (see screenshot below): screen is empty, without any confirmation messsage.

Last edited 6 weeks ago by audrasjb (previous) (diff)

@audrasjb
6 weeks ago

edge case that occurs after user registration

@bmartinent
6 weeks ago

This new patch do not interfere with the other checkemail cases. "wp-login.php?checkemail=newpass" and "wp-login.php?checkemail=registered"

@florianatwhodunit
6 weeks ago

Before patch : form is displayed

@florianatwhodunit
6 weeks ago

After patch : step 1

@florianatwhodunit
6 weeks ago

After patch : step 2 : works fine

#23 @florianatwhodunit
6 weeks ago

  • Keywords needs-testing needs-refresh removed

Hi guys !

I've tested the last patch from @bmartinent .
It works well on my site. See screenshots above for reference ;)

thx for the patch, have a lovely day !
Florian

#24 @audrasjb
5 weeks ago

Patch looks good here as well, thanks.

#25 @audrasjb
5 weeks ago

  • Keywords commit added

Adding commit workflow keyword.

#26 @SergeyBiryukov
4 weeks ago

In 48303:

Login and Registration: Remove newpass value handling in wp-login.php.

This value is never set as of [15710].

See #40605.

#27 @SergeyBiryukov
4 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 48304:

Login and Registration: Hide the login form on the "check your email" step of new user registration or password reset.

This aims to reduce some confusion and make it clearer that the email should be checked before attempting to log in right away.

Props rianrietveld, pratik028, bdbch, johnbillion, hankthetank, yashrs, williampatton, audrasjb, bmartinent, florianatwhodunit, henry.wright, birgire, SergeyBiryukov.
Fixes #40605, #41514.

#28 @SergeyBiryukov
4 weeks ago

In 48305:

Login and Registration: Set a more appropriate page title for the "check your email" step of new user registration or password reset.

Follow-up to [48304].

See #40605, #41514.

Note: See TracTickets for help on using tickets.