WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#40615 closed defect (bug) (fixed)

Update twemoji to v2.2.5

Reported by: peterwilsoncc Owned by: peterwilsoncc
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Emoji Keywords: has-patch
Focuses: Cc:

Description

Update Twemoji fallback in core to version 2.2.5 (released Feb) from version 2.2.2.

Diff
https://github.com/twitter/twemoji/compare/v2.2.2...v2.2.5

This update replaces a number of images, a CDN update will be required [cc: @ocean90].

Attachments (1)

40615.diff (5.5 KB) - added by peterwilsoncc 4 years ago.

Download all attachments as: .zip

Change History (8)

#1 @peterwilsoncc
4 years ago

  • Owner set to peterwilsoncc
  • Status changed from new to accepted

#2 @peterwilsoncc
4 years ago

I've created meta#2814 as a sister ticket.

@peterwilsoncc
4 years ago

#3 @peterwilsoncc
4 years ago

  • Keywords has-patch added

In 40615.diff:

  • Replace CDN url with 2.2.5
  • Add second Emoji 4 test to include emoji added since 2.2.5
  • Travis CI results

@pento Could you please do a quick review of the new emoji 4 test?

#4 @pento
4 years ago

I'd be inclined to put shrug first, then technologist - it seems like shrug is more likely to fail, so let's not run two tests where one will often do.

Apart from that, lgtm.

#5 @peterwilsoncc
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 40626:

Emoji: Update Twemoji to version 2.2.5

Updates Twemoji and adds a second Emoji 4 test to include a shrugging man. Emoji 4 is being implemented gradually, while some browsers now support the female technologist, the indifferent shrugging man is breaking things with his presence.

Props peterwilsoncc, pento for code review.
Fixes #40615.

#6 follow-up: @superpoincare
4 years ago

Twemoji 2.3.0 is out. Might need new tests as well for emoji 5. Not sure whether to open a new ticket so notifying participants here.

#7 in reply to: ↑ 6 @peterwilsoncc
4 years ago

Replying to superpoincare:

Twemoji 2.3.0 is out. Might need new tests as well for emoji 5. Not sure whether to open a new ticket so notifying participants here.

Thanks for letting us know, I've created a seperate ticket.

Note: See TracTickets for help on using tickets.