Archive widget doesn't show the selected month name in the frontend widget itself

[Themonic]

Archive widget doesn't show the selected month name like the category widget shows the selected category name, although the widget works fine it always show "Select Month". Tested with Twenty Seventeen and several other themes.

[afercia]

Confirmed, when both widgets are set to "Display as dropdown".

Screenshots to illustrate what happens after selecting a categiry/archive month and page reloads. Worth noting these selects have other accessibility issues (they should not use the change event and have a button to submit) but they should be addressed in a separate ticket. Also, they don't have a no-js fallback.

the selected category is preserved:

the selected month isn't:

[robobot3000]

Added preselecting of the currently opened archive page in the archives dropdown widgets #wcpl2017

[afercia]

Thanks @robobot3000 ! And hello #wcpl2017! Yep, needs to take care of all the cases, yearly/monthly/weekly/daily/. Looks good!

[peterwilsoncc]

Moving to the 5.1 milestone due to the WordPress 5.0 focus on the new
editor (Gutenberg).

[pento]

Patch needs refresh and testing/review.

[robobot3000]

Refreshed patch

[robobot3000]

Attached an updated version of the patch

[robobot3000]

Restored an accidentally deleted PHPdoc @return

[afercia]

Moving to 5.2 consideration.

[audrasjb]

Patch refreshed and added full documentation for the new feature.

[audrasjb]

In 40662.4.diff, I refreshed the last patch against trunk and I added the full inline Documentation for the new feature.

Also, I believe this ticket will deserve a little Dev note if it lands in 5.2.

Cheers,
Jb

[afercia]

Noticed a couple things:

1
The patch needs some coding standards. Please run
phpcs --standard=phpcs.xml.dist src/wp-includes/general-template.php

and fix all the warning/errors marked with [x]

2
As a long-term goal, these selects shouldn't use the change event. For now, there's the need to address a behavior that didn't matter before but is now relevant:

• select a month
• the page reloads displaying the correct month
• select again the default option "Select Month"
• the page reloads: this shouldn't happen
• comparing with what the Categories select does, the JavaScript should be modernized a bit and not trigger a page reload when the default option is selected
• this means the markup should be changed too, to wrap the select with a <form> element (see for inspiration the Categories widget)

[afercia]

Will refresh the patch.

[afercia]

40662.5.diff​ makes phpcs happy and updates the JS part. No need for a <form> element in this case. Looks good to me.

[SergeyBiryukov]

In 44897:

Widgets: Pre-select currently viewed archive in the Archives dropdown widget, for consistency with the Categories widget.

Props robobot3000, audrasjb, afercia, Themonic.
Fixes #40662.

[SergeyBiryukov]

In 44898:

Docs: Add a @since tag for the new $selected parameter of get_archives_link().

See #40662.

[desrosj]

Dev note: ​https://make.wordpress.org/core/2019/04/24/notable-accessibility-changes-in-5-2/