Opened 9 years ago
Closed 9 years ago
#40673 closed defect (bug) (fixed)
WP Oembed in Multisite fails when embedded post comes from a different site of a network.
| Reported by: | imath | Owned by: | swissspidy |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.9 |
| Component: | Embeds | Version: | 4.5.3 |
| Severity: | normal | Keywords: | needs-patch |
| Cc: | Focuses: | multisite |
Description
Steps to reproduce:
1/ Create a post in main site.
2/ Create a new site
3/ Go the dashboard of this site
4/ Create a new post and paste in it the permalink of the post created at step 1.
This happens when the post we're trying to embed comes from a different site. I've added some unit tests to illustrate the issue. Without the patch, these two unit tests are failing:
- test_wp_filter_pre_oembed_result_multisite_sub_othersub
- test_wp_filter_pre_oembed_result_multisite_sub_main
Attachments (3)
Change History (15)
This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.
9 years ago
This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.
9 years ago
#6
@
9 years ago
- Keywords commit added
Just did two minor tweaks in 40673.diff. I think this is good to go.
#8
@
9 years ago
- Keywords needs-patch added; has-patch has-unit-tests commit removed
- Resolution fixed
- Status closed → reopened
The use of ms_is_switched() doesn't seem to be right, see #38253 for a previous case.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
@swissspidy How does 40673.patch look to you?