WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#4068 closed defect (bug) (fixed)

View Post Link Issues (RE: Changeset 5159)

Reported by: Viper007Bond Owned by: rob1n
Milestone: 2.2 Priority: low
Severity: minor Version: 2.2
Component: Administration Keywords:
Focuses: Cc:

Description

RE: [5159]

Oh where to begin...

  • The right margin needs to be a fixed width rather than an em. On large resolutions, it moves onto of the sidebar:

http://img217.imageshack.us/img217/8155/wpvz4.png

  • The CSS declaration should be in the stylesheet rather than inline so that admin skin replacements can change it's location
  • target="_blank" ? Tsk tsk. This isn't valid XHTML. ;)

Attachments (1)

preview-link-fix.diff (395 bytes) - added by rob1n 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 @rob1n8 years ago

(In [5182]) Move inline styles to wp-admin.css. see #4068

comment:2 in reply to: ↑ description @rob1n8 years ago

  • Keywords needs-patch removed
  • Owner changed from anonymous to rob1n

Replying to Viper007Bond:

RE: [5159]

Oh where to begin...

  • The right margin needs to be a fixed width rather than an em. On large resolutions, it moves onto of the sidebar:

http://img217.imageshack.us/img217/8155/wpvz4.png

I can reproduce this. Fix coming up in a bit.

  • The CSS declaration should be in the stylesheet rather than inline so that admin skin replacements can change it's location

Fixed in [5182].

  • target="_blank" ? Tsk tsk. This isn't valid XHTML. ;)

I'll talk to Matt.

@rob1n8 years ago

comment:3 @mdawaffe8 years ago

We'll need to adjust rtl.css too.

Something like

a.view-link {
        right: auto;
        left: 2em;
        margin-right: 0;
        margin-left: 19em;
}

For what's currently in trunk. I didn't look at the attached patch :)

comment:4 @rob1n8 years ago

Ah, I'll do that now.

And the patch doesn't completely work under IE (both 6 and 7). Still "functional," but not perfect ;).

comment:5 @rob1n8 years ago

(In [5183]) Add RTL support for new view-link class. see #4068

comment:6 @rob1n8 years ago

As for the target="_blank" thing, I'll talk to Matt about possibly using a JavaScripty window.open solution. But I'm not overtly concerned about internal HTML validation.

comment:7 @rob1n8 years ago

(In [5185]) Use fixed widths instead of pixels, so it stays the same at all resolutions. see #4068

comment:8 @rob1n8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

The target="_blank" can stay as it is.

Note: See TracTickets for help on using tickets.