View Post Link Issues (RE: Changeset 5159)

[Viper007Bond]

RE: [5159]

Oh where to begin...

• The right margin needs to be a fixed width rather than an em. On large resolutions, it moves onto of the sidebar:

• The CSS declaration should be in the stylesheet rather than inline so that admin skin replacements can change it's location

• target="_blank" ? Tsk tsk. This isn't valid XHTML. ;)

[rob1n]

(In [5182]) Move inline styles to wp-admin.css. see #4068

[rob1n]

Replying to Viper007Bond:

RE: [5159]

Oh where to begin...

• The right margin needs to be a fixed width rather than an em. On large resolutions, it moves onto of the sidebar:

I can reproduce this. Fix coming up in a bit.

• The CSS declaration should be in the stylesheet rather than inline so that admin skin replacements can change it's location

Fixed in [5182].

• target="_blank" ? Tsk tsk. This isn't valid XHTML. ;)

I'll talk to Matt.

[mdawaffe]

We'll need to adjust rtl.css too.

Something like

a.view-link {
        right: auto;
        left: 2em;
        margin-right: 0;
        margin-left: 19em;
}

For what's currently in trunk. I didn't look at the attached patch :)

[rob1n]

Ah, I'll do that now.

And the patch doesn't completely work under IE (both 6 and 7). Still "functional," but not perfect ;).

[rob1n]

(In [5183]) Add RTL support for new view-link class. see #4068

[rob1n]

As for the target="_blank" thing, I'll talk to Matt about possibly using a JavaScripty window.open solution. But I'm not overtly concerned about internal HTML validation.

[rob1n]

(In [5185]) Use fixed widths instead of pixels, so it stays the same at all resolutions. see #4068

[rob1n]

The target="_blank" can stay as it is.