Make WordPress Core

Opened 7 years ago

Closed 6 months ago

#40683 closed enhancement (fixed)

Add a Plugins link to admin bar menu

Reported by: colomet's profile colomet Owned by: joedolson's profile joedolson
Milestone: 6.5 Priority: normal
Severity: normal Version: 4.7.4
Component: Toolbar Keywords: has-patch needs-testing
Focuses: ui Cc:

Description

Now we have acces to :
Dashboard
Themes
Widgets
Menus

Why not acces to Plugins? Why acces to Themes and Menus if once it is finish the site we do not use to change often? http://imgur.com/a/JTarJ

Attachments (7)

Captura de pantalla 2017-05-06 a las 10.48.30.png (17.9 KB) - added by colomet 7 years ago.
sreenshot of the place where the plugin direct acces is missing
40683.patch (501 bytes) - added by Girishpanchal 7 years ago.
40683.2.diff (547 bytes) - added by danieltj 7 years ago.
Refreshed patch for 4.8.1
40683.2.patch (593 bytes) - added by rishishah 7 years ago.
40683.end-of-appearance-group.patch (528 bytes) - added by sabernhardt 3 years ago.
adding Plugins link within the Appearance group again, but at the end
40683.before-appearance.patch (622 bytes) - added by sabernhardt 3 years ago.
adding Plugins link before the Appearance menu items
40683.3.diff (612 bytes) - added by SergeyBiryukov 7 months ago.

Download all attachments as: .zip

Change History (26)

@colomet
7 years ago

sreenshot of the place where the plugin direct acces is missing

#1 @Girishpanchal
7 years ago

  • Focuses ui removed
  • Keywords has-patch added

@colomet The "Plugin" menu is not required to everyone as a shortcut menu on admin bar but if everybody agrees to add plugin shortcut then i have added patch for same.

I have added "Plugin" shortcut menu option after the "Menus" which shows if current user has capability to install plugins like current_user_can( 'install_plugins' ). Please see the below attached snapshot.

http://www.awesomescreenshot.com/image/2466653/47c2324998660de213aea6396c0d610b

@Girishpanchal
7 years ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


7 years ago

#3 @afercia
7 years ago

  • Component changed from Administration to Toolbar
  • Focuses ui added; accessibility administration removed

Removing the accessibility focus, as per today's accessibility bug scrub. More related to UI.

#4 @afercia
7 years ago

Related: #32678

@danieltj
7 years ago

Refreshed patch for 4.8.1

#5 @danieltj
7 years ago

  • Keywords needs-testing added

Refreshed the patch with a couple of changes.

  • Add plugins after the themes link but before any other potential extra links.
  • Capability for link is activate_plugins.

#6 @SergeyBiryukov
7 years ago

  • Summary changed from plugin direct acces from admin header menu to Add a Plugins link to admin bar menu

This ticket was mentioned in Slack in #core by danieltj. View the logs.


7 years ago

@rishishah
7 years ago

This ticket was mentioned in Slack in #core by danieltj. View the logs.


6 years ago

#9 @SergeyBiryukov
6 years ago

#41013 was marked as a duplicate.

@sabernhardt
3 years ago

adding Plugins link within the Appearance group again, but at the end

@sabernhardt
3 years ago

adding Plugins link before the Appearance menu items

#10 @sabernhardt
3 years ago

The new Plugins link would not belong between Appearance and Menus.

I prefer placing the new link before the set of Appearance links 40683.before-appearance.patch . However, that does not match the order of links in the side admin menu, so I made another option with Plugins at the end of the Appearance group 40683.end-of-appearance-group.patch .

Both patch options use the ID of 'ab-plugins' (similar to ab-icon and ab-item) to avoid any confusion with links added by plugins. A directory search found some nodes with a 'plugins' ID. Of course, this one could have a better name, too.

#11 follow-up: @joedolson
8 months ago

  • Milestone changed from Awaiting Review to 6.5
  • Owner set to joedolson
  • Status changed from new to accepted

Speaking personally, I have a need to go to the plugins screen *much* more frequently than I do the themes screen.

I think this would be a good change, and makes a lot of sense. It's not clear to me why plugins don't have equal relevance here; it's a very comparable use case to themes or widgets, e.g. jumping back and forth between admin and front-end comparing how a given choice works for you.

I would put Plugins before 'Themes', to match the order in the admin menu. However, it's a short enough menu that I could be convinced otherwise.

#12 @huzaifaalmesbah
7 months ago

Test Report

Patch tested: 40683.before-appearance.patch

Environment

  • WordPress: 6.5-alpha-56966-src
  • PHP: 7.4.33
  • Server: nginx/1.25.2
  • Database: mysqli (Server: 5.7.43 / Client: mysqlnd 7.4.33)
  • Browser: Chrome 118.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Four 1.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.0.0

Actual Results

  1. This patch Add Plugins link before the Appearance ✅

Screenshots

Before Apply Patch After Apply Patch ✅
https://i.ibb.co/pZwHH83/Screenshot-2023-11-12-at-8-04-46-PM.png https://i.ibb.co/647JVfm/Screenshot-2023-11-12-at-8-04-26-PM.png

#13 in reply to: ↑ 11 @SergeyBiryukov
7 months ago

Replying to joedolson:

I would put Plugins before 'Themes', to match the order in the admin menu.

Unless I'm missing something, Plugins comes after Themes, both in the regular admin menu and in the Network Admin menu. So placing the link after the Appearance group would be my preference here.

Placing it in the wp_admin_bar_appearance_menu() function, as in 40683.end-of-appearance-group.patch, doesn't feel right to me though, as plugins are not in the Appearance group. After the wp_admin_bar_appearance_menu() call in wp_admin_bar_site_menu() seems like a better place.

Replying to sabernhardt:

Both patch options use the ID of 'ab-plugins' (similar to ab-icon and ab-item) to avoid any confusion with links added by plugins. A directory search found some nodes with a 'plugins' ID. Of course, this one could have a better name, too.

There appear to be false positives in those search results. Most of the instances are unrelated to the admin bar, and most of the related ones use it for the same purpose (linking to the Plugins screen). I think we can just use 'plugins' here, for consistency with the existing naming scheme: 'themes', 'widgets', 'menus', etc. Plugins that are still supported should adapt to the change.

40683.3.diff is a refresh with the above in mind.

#14 @shailu25
7 months ago

Test Report

Patch Tested: https://core.trac.wordpress.org/attachment/ticket/40683/40683.3.diff

Environment:

WordPress - 6.5-alpha-56966-src
OS - Windows
Browser - Chrome
Theme: Twenty Twenty One
PHP - 8.0.18
Active Plugin - None

Actual Results:

  • This patch Adds Plugins link in admin bar✅

Screenshots:

Before Patch: https://prnt.sc/KTHZYZowOEvx
After Patch : https://prnt.sc/ZSkPAIbkot2i

#15 @zunaid321
7 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/40683/40683.3.diff

Environment

  • WordPress: 6.5-alpha-56966-src
  • PHP: 8.2.12
  • Server: nginx/1.25.3
  • Database: mysqli (Server: 5.7.44 / Client: mysqlnd 8.2.12)
  • Browser: Chrome 119.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Twenty-Four 1.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.0.0

Actual Results

  1. ✅ Plugins Link shows up in the admin bar.

Supplemental Artifacts

After Patch: https://i.ibb.co/bzy5J2G/2023-11-17-16-12.png

#16 @devmuhib
7 months ago

Test Report

Description

Patch working fine. ✅

Patch tested: https://core.trac.wordpress.org/attachment/ticket/40683/40683.3.diff

Environment

  • WordPress: 6.5-alpha-56966-src
  • PHP: 7.4.33
  • Server: nginx/1.25.2
  • Database: mysqli (Server: 5.7.43 / Client: mysqlnd 7.4.33)
  • Browser: Chrome 119.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Twenty-Three 1.3
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.0.0
    • WP System Info 1.5

Actual Results

  1. ✅ Issue resolved with patch.

Supplemental Artifacts

Before applying patch:

https://i.imgur.com/67XNUsc.png

After applying patch:

https://i.imgur.com/U1P0Nxw.png

#17 @sumitbagthariya16
6 months ago

Test Report ✅

Patch tested: https://core.trac.wordpress.org/attachment/ticket/40683/40683.3.diff

Environment

  • WordPress: 6.5-alpha-56966-src
  • PHP: 7.4.33
  • Server: nginx/1.25.2
  • Browser: 119.0.6045.199 (Official Build) (x86_64)
  • OS: macOS Ventura 13.3
  • Theme: Twenty Eleven 4.5

Screenshot
https://prnt.sc/52DItsBn6tdS

Test status:
The patch is working fine. ✅

#18 @yuvrajsinh2211
6 months ago

Test Report

Testing of Patch: https://core.trac.wordpress.org/attachment/ticket/40683/40683.3.diff

Environment:

WordPress: 6.5-alpha-56966-src
PHP: 8.1.9
OS: Windows
Browser: Chrome
Theme: Twenty Twenty One
Plugins: None

Screenshots:

Before applying patch: https://prnt.sc/_jW_k3ubXcuL
After applying patch: https://prnt.sc/8FF7hEsT-IvB

Actual Results:

The patch is working properly.✅

#19 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 57188:

Toolbar: Add a Plugins link to the admin bar menu.

Props colomet, Girishpanchal, afercia, danieltj, rishishah, sabernhardt, joedolson, huzaifaalmesbah, shailu25, zunaid321, devmuhib, sumitbagthariya16, yuvrajsinh2211, SergeyBiryukov.
Fixes #40683.

Note: See TracTickets for help on using tickets.