no chance to control wp_count_terms ()

[krizkroz]

Hey!

I'm wondering if i have no chance to filter the resulting number of wp_count_terms ().
Theres no filter available there.

wp_count_terms () calls get_terms () but it returns the result of $term_query before ("Count queries are not filtered, for legacy reasons.") the "get_terms" filter is appliable. So i see no chance to control result of wp_count_terms () without (heavy) diggin in to WP_Term_Query().

Is there a chance for a filter before the function returns in this case?

thank you a lot,
Christian

[SergeyBiryukov]

#49411 was marked as a duplicate.

[jignashu]

Added filter to modify wp_count_terms arguments.

[jignashu]

By mistake changed to invalid.

[amitkumarsingh]

Added a filter to modify the arguments of wp_count_terms. Similar to above solution but I think having a filter name like wp_count_terms_args would make more sense.

Checkout the diff, I just uploaded below.

[jaydeeptrivedi404]

@amitkumarsingh @jignashu Wont it be better to have a filter directly for the result?

[jignashu]

@jaydeeptrivedi404 yes, it is good to have it on the result as well but it also required before calling the get_terms() to modify the arguments of the function.

[ddu66]

Hello.
I don't understand some of your proposals regarding of initial request.
As I explain in ticket #49411 (duplicate), the need is to filter result exactly the same way wp_count_posts (wp-includes/posts.php) does.
wp_count_terms function should then terminate with:

return apply_filters('wp_count_terms', get_terms($args), $taxonomy, $args);

Thank you.

[jignashu]

Changed the name of the filter as well as added block comments for that filter.

[ddu66]

Filtering the result give user more control and make wp_count_terms mostly coherent with wp_count_posts function.
In another hand, I think that filtering args should be done by get_terms instead of wp_count_terms.

[ddu66]

Hello.
4 years later, the need for a filter call before returning is still present.
Would it be possible to take this request into account ?
Filtering the args could by interesting but doesn't give the hability to return terms that are not present in the database (and this is exactly the need).
Regards.

[ddu66]

Up!

[audrasjb]

Hello,

Sorry for the long delay and thank you for the patch @ddu66.
Moving for 6.1 consideration and self-assigning for review.

Trac ticket: https://core.trac.wordpress.org/ticket/40696

[peterwilsoncc]

I'd like to wrap up #40351 before putting this in.

The intention is to improve the performance of term counts significantly so there is a risk adding a filter would block that in an effort to maintain backward compatibiltiy.

[desrosj]

Replying to peterwilsoncc:

I'd like to wrap up #40351 before putting this in.

The intention is to improve the performance of term counts significantly so there is a risk adding a filter would block that in an effort to maintain backward compatibiltiy.

I agree with this. Since #40351 is still marked Future Release, let's also move this one there.