WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#40725 closed defect (bug) (fixed)

Fix using incorrect network option name in unit tests.

Reported by: flixos90's profile flixos90 Owned by: flixos90's profile flixos90
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.8
Component: Networks and Sites Keywords: has-patch
Focuses: multisite Cc:

Description

The unit tests introduced as part of [40486] use a wrong network option name (site_option instead of blog_option). This doesn't cause actual issues in the test, but deleting the option should verify that it is properly recreated afterwards, so the usage of the wrong name makes this test less useful.

Attachments (1)

40725.diff​ (908 bytes) - added by flixos90 8 years ago.

Download all attachments as: .zip

Change History (3)

@flixos90
8 years ago

#1 @flixos90
8 years ago

  • Keywords has-patch added; needs-patch removed

#2 @flixos90
8 years ago

  • Owner set to flixos90
  • Resolution set to fixed
  • Status changed from new to closed

In 40611:

Multisite: Fix usage of incorrect site_count network option name in unit tests.

The unit tests introduced as part of [40486] used the wrong site_count network option name instead of blog_count. This did not cause actual issues in the tests, but deleting the option was supposed to verify that it is properly recreated afterwards. The usage of the wrong name made these tests less useful, so this changeset fixes it.

Fixes #40725.

Note: See TracTickets for help on using tickets.