WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#40726 closed defect (bug) (fixed)

Editor: QuickTags does not trigger change event when text modified

Reported by: westonruter's profile westonruter Owned by: azaozz's profile azaozz
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

In testing the new TinyMCE-powered Text widget (#35243), I tried switching to the Text tab and I selected some text and clicked a QuickTag. If I make no other change, then in the widgets admin screen when I hit Save the tags that were added then get lost. Likewise, in the customizer, if I hit a QuickTag then the preview is not affected. The problem is that the change event is not being fired on the textarea and so the widgets admin screen and customizer alike do not detect that a change was made.

Attachments (1)

40726.0.diff​ (2.2 KB) - added by westonruter 8 years ago.

Download all attachments as: .zip

Change History (4)

@westonruter
8 years ago

#1 @westonruter
8 years ago

  • Keywords has-patch added
  • Owner set to azaozz
  • Status changed from new to reviewing

This ticket was mentioned in ​Slack in #core-customize by westonruter. ​View the logs.
8 years ago

#3 @azaozz
8 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 40615:

Editor: manually trigger change event when text is modified from JS.

Props westonruter.
Fixes #40726.

Note: See TracTickets for help on using tickets.