Semantic elements for non-link links: theme-install.php

[Cheffheid]

The filters on the theme install page (Featured, Popular, Latest, Favorites) are currently marked up with anchor tags, but they should be marked up with buttons.

A downside to doing so is that the focus styles persist when the buttons are clicked, which may not look great.

Attached first pass patch removes the outline on focus for browsers that add one by default (Chrome, IE11, Edge, possibly Safari) to minimize the effect, but would definitely appreciate some help in coming up with a good solution for it instead.

[Cheffheid]

First pass - changes anchors to buttons, updates CSS / JS selectors to include buttons.

[Cheffheid]

Changes in action in Chrome, sans outline:

[afercia]

Worth noting things have changed a bit and the theme browser has now implemented routing and browser history. DIscussed a bit during today's accessibility bug-scrub and agreed it needs to be re-evaluated.

[Cheffheid]

Oh, well, look at that. :)

This entire page gets disabled when there is no JavaScript, so is there value in changing the hash to something useful as a fallback (beyond these links not coming up in a href="#" search anymore, that is)?

I would probably want to lean towards no and am fine with closing this. The links actually act a bit more like links now and so I think they're fine semantically.

(I'll set a reminder for the next bug scrub, too >.>)

[Cheffheid]

As discussed on the 22/01/2018 bug scrub, I'm closing this and opening a new ticket for some of the (mostly unrelated to semantics) issues that are on the feature filter toggle button. :)