WordPress.org

Make WordPress Core

Opened 14 months ago

Closed 5 months ago

Last modified 3 months ago

#40747 closed enhancement (invalid)

Semantic elements for non-link links: theme-install.php

Reported by: Cheffheid Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords: semantic-buttons has-patch
Focuses: ui, accessibility Cc:

Description

The filters on the theme install page (Featured, Popular, Latest, Favorites) are currently marked up with anchor tags, but they should be marked up with buttons.

A downside to doing so is that the focus styles persist when the buttons are clicked, which may not look great.

Attached first pass patch removes the outline on focus for browsers that add one by default (Chrome, IE11, Edge, possibly Safari) to minimize the effect, but would definitely appreciate some help in coming up with a good solution for it instead.

Attachments (1)

40747.patch (4.0 KB) - added by Cheffheid 14 months ago.
First pass - changes anchors to buttons, updates CSS / JS selectors to include buttons.

Download all attachments as: .zip

Change History (11)

@Cheffheid
14 months ago

First pass - changes anchors to buttons, updates CSS / JS selectors to include buttons.

#1 @Cheffheid
14 months ago

Changes in action in Chrome, sans outline:

http://i.imgur.com/g72onPE.gif

#2 @Cheffheid
14 months ago

  • Keywords semantic-buttons has-patch added

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


13 months ago

#4 @afercia
13 months ago

  • Focuses ui added
  • Milestone changed from Awaiting Review to Future Release
  • Version trunk deleted

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


5 months ago

#6 @afercia
5 months ago

Worth noting things have changed a bit and the theme browser has now implemented routing and browser history. DIscussed a bit during today's accessibility bug-scrub and agreed it needs to be re-evaluated.

#7 @Cheffheid
5 months ago

Oh, well, look at that. :)

This entire page gets disabled when there is no JavaScript, so is there value in changing the hash to something useful as a fallback (beyond these links not coming up in a href="#" search anymore, that is)?

I would probably want to lean towards no and am fine with closing this. The links actually act a bit more like links now and so I think they're fine semantically.

(I'll set a reminder for the next bug scrub, too >.>)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


5 months ago

#9 @Cheffheid
5 months ago

  • Resolution set to invalid
  • Status changed from new to closed

As discussed on the 22/01/2018 bug scrub, I'm closing this and opening a new ticket for some of the (mostly unrelated to semantics) issues that are on the feature filter toggle button. :)

#10 @ocean90
3 months ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.