WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Last modified 9 years ago

#40760 new enhancement

Make Walker_Page::start_lvl more flexible by introducing filters for class name(s) at least

Reported by: pbiron's profile pbiron Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch
Focuses: Cc:

Description

Related: #36163, #40359, #40666

We should harmonize the filters available in the 3 main Walker classes.

Attachments (1)

40760.diff​ (1.0 KB) - added by rahulsprajapati 9 years ago.
Add the filters available in the 3 main Walker classes to Walker_Page class.

Download all attachments as: .zip

Change History (7)

#1 @pbiron
9 years ago

Related: #40761

#2 @pbiron
9 years ago

  • Keywords needs-patch added

@rahulsprajapati
9 years ago

Add the filters available in the 3 main Walker classes to Walker_Page class.

#3 @rahulsprajapati
9 years ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in ​Slack in #accessibility by afercia. ​View the logs.
9 years ago

#5 follow-up: @afercia
9 years ago

  • Focuses accessibility removed

If this is just about adding CSS classes, and not also things like aria-current as in #40359, I'd prefer to remove the accessibility focus to keep the a11y tickets report clean. Please do feel free to re-add it if I'm missing something.

#6 in reply to: ↑ 5 @pbiron
9 years ago

Replying to afercia:

If this is just about adding CSS classes, and not also things like aria-current as in #40359, I'd prefer to remove the accessibility focus to keep the a11y tickets report clean. Please do feel free to re-add it if I'm missing something.

I had commented on #36163 that it would be good to do the same for the other Walker classes and @peterwilsoncc asked me to open individual tickets for the other classes.

I can't speak for anyone else, but my interest is in @aria-current. That's why I added the accessiblity focus to this and #40761.

I haven't had a chance yet to look at the patch provided by @rahulsprajapati to see if it covers the general case (i.e., going beyond @class) that I'm interested in.

Note: See TracTickets for help on using tickets.