WordPress.org

Make WordPress Core

Opened 5 months ago

Last modified 6 weeks ago

#40774 new enhancement

Refine error message when embedding invalid Video (URL)

Reported by: Presskopp Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.8
Component: Media Keywords: has-patch needs-testing needs-refresh
Focuses: Cc:

Description

like in #40771 you get the following error when your link is invalid:

Sorry, we can’t display the video file type selected. Please select a supported video file (...) or stream (YouTube or Vimeo) instead.

When posting an incomplete youtube link for example it's not the file type but a character wrong or missing.

I propose to change the error message like in the patch attached:

Sorry, either the selected file type is not supported or the video stream is invalid. Please make sure to select one of the following video file types (%1$s) or a valid stream (YouTube or Vimeo) instead.

Attachments (1)

40774.diff (1.1 KB) - added by Presskopp 5 months ago.

Download all attachments as: .zip

Change History (7)

@Presskopp
5 months ago

#1 @jnylen0
5 months ago

This is good as an incremental improvement, and worth committing by itself IMO, but I think we can probably go a bit further here. What are the failure conditions we expect? For example:

  • Non-video file type (can we show the actual file type we received instead?)
  • Non-200 response (can we show the response code or some text about it instead?)
  • Response failed, blocked by browser (#40771; can we detect this?)

This ticket was mentioned in Slack in #core-media by presskopp. View the logs.


3 months ago

#3 @jbpaul17
3 months ago

  • Keywords has-patch needs-testing added

#4 @jbpaul17
3 months ago

  • Keywords needs-refresh added

This ticket was mentioned in Slack in #core-media by presskopp. View the logs.


3 months ago

This ticket was mentioned in Slack in #core-media by presskopp. View the logs.


6 weeks ago

Note: See TracTickets for help on using tickets.