WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #40779


Ignore:
Timestamp:
05/16/2017 02:52:51 PM (4 years ago)
Author:
johnjamesjacoby
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #40779 – Description

    initial v1  
    11A few `function_exists()` checks can be removed from `wp-db.php`, thanks to recent load order changes, probably nobody having looked in a while, and generally being afraid to break DB drop-ins:
    22
    3 All of these are ahead of `require_wp_db()`:
     3All of these functions are in files now loaded ahead of `require_wp_db()`:
    44
    5 * `function_exists('is_multisite')` (load.php)
    6 * `function_exists('_deprecated_function')` (functions.php)
    7 * `function_exists( 'mb_strlen' )` (compat.php)
    8 * `mb_check_encoding()` could *maybe* be a new function in compat.php (it's used 3 times)
     5* `is_multisite` (load.php)
     6* `_deprecated_function` (functions.php)
     7* `mb_strlen` (compat.php)
     8
     9Bonus:
     10
     11* `mb_check_encoding()` could *maybe* be a new function in compat.php (it's used 3 times in core, using `@` or `function_exists`)
    912
    1013----
    1114
    12 The only caveats are 10+ year-old HyperDB versions that do the old-school deep-integration thing, of directly including files – they'll need extra scrutiny.
     15The only caveats are the installation process, and 10+ year-old HyperDB versions that do the old-school deep-integration thing, of directly including files – they'll need extra scrutiny.