WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#40792 closed enhancement (fixed)

Adding Someecards.com as an oEmbed provider

Reported by: someecards Owned by: johnbillion
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch needs-testing
Focuses: Cc:

Description

This ticket is a request to have someecards.com added to the list of oEmbed providers.

Is the service is popular enough for core developers to have heard of it before? Is it “mainstream?”

We hope so. Someecards has been around for a while and is pretty popular.

If similar services are already supported, how does this service compare in terms of size, features, and backing?
Various image embed exists like imgur that are similar in some ways. Someecards is pretty popular. See social stats below.

Does this service have a large following on Twitter, Facebook, or other social media? Is its Twitter account verified?
https://www.facebook.com/someecards/ (5.8M)
https://twitter.com/someecards (verified, 2.35M)

Is its oEmbed endpoint clearly established and properly documented? (Sometimes, they are just a developer’s pet project that may not be supported.)
https://github.com/someecards/someecards-developer-docs/blob/master/oembed.md

Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being whitelisted?
It works.

Does the service make an effort to build relationships with developers, such as through robust APIs?
We're not making tons of open APIs currently.

How old is the service?
Someecards.com was started in 2006.

Does it have a well-established Wikipedia article? (Seriously.)
https://en.wikipedia.org/wiki/Someecards

Has anyone written a WordPress plugin that leverages the service in some way, whether adding it as an oEmbed provider, creating a shortcode, or leveraging other APIs of the service? Do these plugins have any noticeable adoption or traction that would indicate usage and demand?
Not that we know of but we're convinced this oembed support would be useful.

Is the provider frequently proposed?
Oembed rich media support was added a couple months ago so this is likely the first request.

Attachments (2)

someecards.diff (1.6 KB) - added by someecards 4 years ago.
someecards.2.diff (1.6 KB) - added by someecards 3 years ago.
updated WP version to 4.9.0

Download all attachments as: .zip

Change History (11)

#1 follow-up: @ocean90
4 years ago

Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being whitelisted?
It works.

If that's true we don't have to add a provider to the whitelist because it should already work.

#2 in reply to: ↑ 1 @someecards
4 years ago

Replying to ocean90:

Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being whitelisted?
It works.

If that's true we don't have to add a provider to the whitelist because it should already work.

Ahh you are correct. I misunderstood the question. As this uses javascript, auto-discovery is not enough and whitelisting is needed. Thanks!

#3 @someecards
3 years ago

Hi, does anybody have a chance to take a quick look at this? We actually worked with a Wordpress blogger recently to get this embed working in a manual way because they weren't able to paste the URL into the WYSIWYG. We'd be very excited to get this patch in for the future.

#4 @johnbillion
3 years ago

  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to 4.9
  • Version trunk deleted

This missed the boat for 4.8 but we can look at it for 4.9.

@someecards
3 years ago

updated WP version to 4.9.0

#5 @someecards
3 years ago

Hi everybody,

Let us know if there's anything we can do here.

Thanks!

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


3 years ago

#7 @johnbillion
3 years ago

  • Owner set to johnbillion
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


3 years ago

#9 @johnbillion
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 41681:

Embeds: Add oEmbed support for someecards.com.

Props someecards

Fixes #40792

Note: See TracTickets for help on using tickets.