Twenty Seventeen: Overriding WordPress globals is prohibited

[maneshtimilsina]

In Twenty Seventeen theme, global variable $post is overridden at line 145 of /inc/template-tags.php

As per theme review guidelines Overriding WordPress globals is prohibited.

[swissspidy]

Hey there,

Thanks for your report and welcome to Trac!

They way themes like Twenty Seventeen need to set up front page sections, overriding $post is really to only way.

What isn't needed is the first global $post on line 142. Also, before the global post is set, it's not really checked if get_theme_mod( 'panel_' . $id ) really is a valid post.

[maneshtimilsina]

Hi @swissspidy

Thanks for reply.

Yes, global $post on line 142 has no use. Also, if $id returns integer value is not checked anywhere.

Next, $post is overridden to use its ID in content-front-page-panels.php we can get this option by creating custom global variable and assigning post ID. We need to change the_title() in content-front-page-panels.php to get_the_title( $global_variable )

If you like to test, I can provide you working code.

Thank you.

[smit08]

Hi @swissspidy, I looked into the issue. I think we need to update the description. I checked the /inc/template-tags.php file and found that the $post variable is overridden, but it is now on line 155.

Here is the line I found, along with the comment:

global $post; // Modify the global post object before setting up post data.

[smit08]

Hi @swissspidy, As mentioned in my previous comment, the code line has been updated, and this issue can be resolved using the patch I provided. If we decide to proceed with the fix, we can apply my patch. I would appreciate it if a tester could review and test my patch. Thank you in advance.