WordPress.org

Make WordPress Core

Opened 5 weeks ago

Closed 5 weeks ago

Last modified 5 weeks ago

#40800 closed defect (bug) (fixed)

Incorrect translation call in script-loader.php

Reported by: leewillis77 Owned by: swissspidy
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.6
Component: Media Keywords: has-patch
Focuses: Cc:

Description

Currently script-loader.php contains the following call:

__( 'None', 'no captions/subtitles' )

Here "no captions/subtitles" is used as the text domain, when it should be the context. Patch attached.

Attachments (1)

40800.diff (703 bytes) - added by leewillis77 5 weeks ago.
Patch

Download all attachments as: .zip

Change History (3)

@leewillis77
5 weeks ago

Patch

#1 @swissspidy
5 weeks ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from new to closed

In 40775:

Media: Correct a translatable string for MediaElement.js.

Adds the needed context to the string "None". Introduced in [38089].

Props leewillis77.
See #37394.
Fixes #40800.

#2 @swissspidy
5 weeks ago

  • Component changed from General to Media
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.8
  • Version changed from trunk to 4.6

Thanks @leewillis77, good catch!

Note: See TracTickets for help on using tickets.