Audio or video files do not show on upload

[karmatosed]

I think this is a media library issue, but I discovered it whilst testing the audio widget.

If you drag a file it doesn't appear in the library. Here is a gif to show:

It's worth noting for images, this does, here is a gif of that:

What would be great would be for the behaviour to be constant.

edit: updated to video also as issue thanks to @desrosj finding that

[desrosj]

I am also seeing this, but also happens with videos for me. Using Chrome v 58.0.3029.110.

[timmydcrawford]

To confirm, the same issue is happening when interacting with the media modal within the post editor - or is it only happening when using the audio widget?

[desrosj]

Replying to timmydcrawford:

To confirm, the same issue is happening when interacting with the media modal within the post editor - or is it only happening when using the audio widget?

I do not see the same behavior when editing a post. After uploading a video, it appears in the media library properly.

[karmatosed]

@timmydcrawford only in widgets. Just tested and works for post/pages.

Changing to widgets to confirm.

[desrosj]

Also, just to add details from our Slack conversation to the ticket.

When opening the modal initially, all pre-existing files of the correct type show up in the modal. This includes any files uploaded on previous page loads using the media widget. This is also not just a Customizer issue, it happens for me when editing media widgets in the admin as well.

[timmydcrawford]

Okay I have tracked down the issue here - it appears that by passing in the list of mimes for a given media type in https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/widgets/media-widgets.js#L252, the underlying query.args.post_mime_type the media modal uses to query/update the listing uses this same list of extensions.

So in the case of the audio widget, the mime which is passed in when creating the insert state for the media modal is audio/mpeg,audio/ogg,audio/mpeg,audio/wav. If you contrast that against the a media modal in the editor, with the "audio" filter set, the post_mime_type in the query is just audio.

40803.1.diff​ fixes the issue by only passing in the media widgets mime type, instead of the explicit list of mime types. This logic was originally introduced in ​https://github.com/xwp/wp-core-media-widgets/pull/173 to handle the filtering of .mov files so they would not show up as selectable in the video widget modal. So with this diff, .mov files do show up, but when selected an error is still shown in the preview.

It does seem to me that there might be a way to fix this in the wp.media logic too - because the initial display of the media modal with the explicit mimes works properly, just the subsequent refresh from observing uploads does not.

/cc @westonruter

[timmydcrawford]

removing whitespace changes

[timmydcrawford]

Dug a bit further and it looks like if we pass in an array of specific mime types, the query performs as expected. 40803.3.diff​ shows this approach, and maintains the proper filtering of .mov files. Note you can still drag and drop or upload a .mov file - but the original issue reported here is fixed by this diff.

[westonruter]

Related issue of restricting file types during upload: ​https://github.com/xwp/wp-core-media-widgets/issues/128

[karmatosed]

@timmydcrawford tested and confirm this fixes the reported issue.

[westonruter]

In 40836:

Widgets: Ensure that audio and video files appear in media library browser upon upload.

Props timmydcrawford.
Amends [40640].
See #32417, #39994, #39995.
Fixes #40803.